Giter Club home page Giter Club logo

Comments (5)

gsantiago avatar gsantiago commented on May 11, 2024 8

Indeed, I could format, parse and normalize the values before and after the form submission. But then I would lose the capability to use the combination between format and normalize to create masks for input.

With redux-form, I can do things like this:

<Field
  name='phone'
  component='input'
  type='tel'
  format={value => mask(value, '(99) 9999-9999')} /* mask the input for the user */
  normalize={value => value.replace(/\D/g, '')} /* internally, store only the numbers to send to server later */
  validate={value => !validatePhone(value) && 'Invalid phone'}
/>

That's it. I don't have to depend on more heavy libraries like react-text-mask just to mask the inputs.

The other reason is that I like to keep validation and value lifecycle logic in the Field component itself. If I change the Field name, update some logic in the lifecycle or remove it, then I would just change the Field component and not change objects or functions in different parts of my code.

I understand if you want to keep the react-final-form simple and not include these features (I like the idea of keeping the react-final-form simple 😄). I would probably solve this problem by creating a custom component and pass it to the Field.

from react-final-form.

dispix avatar dispix commented on May 11, 2024 6

I agree with @gsantiago, the value lifecycle was a really simple and nice way to separate the data from the display. I think that there are quite a lot of cases where the value stored in the form state and the value passed to the "dumb" component need to be handled differently.

from react-final-form.

erikras avatar erikras commented on May 11, 2024 1

Published fix in v2.1.0.

from react-final-form.

erikras avatar erikras commented on May 11, 2024

Hmm... I was hoping to not need to implement that, instead laying the burden of formatting and parsing on the code that initializes and submits the form. Can you make an argument for why you think you need it?

from react-final-form.

lock avatar lock commented on May 11, 2024

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from react-final-form.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.