Should results be cached when the request isn't succesful about strathweb.cacheoutput HOT 2 CLOSED

Further investigation In CacheOutputAttribute.OnActionExecuted shows:

• the code tries to set the ETag on the response if Repsonse is null (as happen when the Action threw a normal Exception). This fails with an exception.
• the code tries Rersponse.Content.ReadAsStringAsync() when Content is null (as happens when the Action threw a HttpResponseException)

Both problems can be fixed by adding

if (actionExecutedContext.ActionContext.Response == null || !actionExecutedContext.ActionContext.Response.IsSuccessStatusCode) return;

as the first line of OnActionExecuted.
I'd be happy to provide a patch including unittests if that's the right thing to do.

from strathweb.cacheoutput.

Hey you are totally right - that would be great.
Additionally, we should check

if (actionExecutedContext.ActionContext.Response.Content != null)
{ //now save to cache }

after setting Etag & before reading content to store in cache (since response may not be null, but content might).

from strathweb.cacheoutput.