Giter Club home page Giter Club logo

Comments (5)

markcellus avatar markcellus commented on May 22, 2024 1

This is what "can break some websites" means.

I don't know if this was meant to be sarcastic and snarky or not but I know what "can break some websites" means. Furthermore, the statement is very vague and misleading when the PWA works fine on first load but doesn't work after login has expired. You're essentially stuck in an infinite redirect and unable to even open the PWA after the login expires.

I know right clicking will allow me to select "Open Link in Default Browser", but expecting users to do this every time they click a link in a PWA isn't plausible or helpful.

so it is impossible to fix this

There are many ways this can be handled so maybe we should talk about possible solutions rather than to just dismiss this as something that can't be addressed. One option is to allow a way for the user to whitelist the redirect URLs so that they still open in the PWA even if "Open out of scope URLs in a default browser (can break some websites)" option is checked. Is something like that possible?

from pwasforfirefox.

filips123 avatar filips123 commented on May 22, 2024 1

You can press F6 and then enter about:config in the popup.

from pwasforfirefox.

filips123 avatar filips123 commented on May 22, 2024

This is what "can break some websites" means. Login redirects are still the same as any other external URL request, so it is impossible to fix this.

You can disable "Open out of scope URLs in a default browser (can break some websites)" and instead use "Open in Browser" widget or "Open Link in Default Browser" context menu action if you want to easily open URLs in a default browser.

from pwasforfirefox.

filips123 avatar filips123 commented on May 22, 2024

Furthermore, the statement is very vague and misleading when the PWA works fine on first load but doesn't work after login has expired.

This is because it can cause different behaviors for different websites.

One option is to allow a way for the user to whitelist the redirect URLs so that they still open in the PWA even if "Open out of scope URLs in a default browser (can break some websites)" option is checked. Is something like that possible?

Yeah, I forgot about this, but you can set firefoxpwa.allowedDomains in about:config to a comma-separated list of domains that shouldn't be opened in the main browser.

from pwasforfirefox.

markcellus avatar markcellus commented on May 22, 2024

Thanks. How do I set this firefoxpwa.allowedDomains config in a PWA? It doesn't allow me to type about:config in the URL bar.

from pwasforfirefox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.