Giter Club home page Giter Club logo

Comments (3)

filips123 avatar filips123 commented on May 22, 2024 1

Version is indeed hardcoded into the path in several files, and it is set here using the Homebrew bin which should be always updated to the correct version. However, it seems I forgot that PWA loaders also include versioned path to binary which is not updated.

I think I can solve this if I change bin in the formula (and share) to opt_bin which I think will use unversioned path.

from pwasforfirefox.

filips123 avatar filips123 commented on May 22, 2024

I have published update/rebuild to 1.1.0 in my Homebrew tap which should fix this issue (but it required some manual work). Can you check if it works so I can create PR to official Homebrew tap?

  1. Activate my tap: brew tap filips123/firefoxpwa
  2. Install/update new FirefoxPWA from tap: brew install filips123/firefoxpwa/firefoxpwa
  3. Edit/update all existing PWAs through extension or command-line program to apply the fix to PWAs. This is unfortunately unavoidable and will need to be done even when update in the official tap is released.
  4. Check if PWA loader file contains versioned path or not (it should not).

from pwasforfirefox.

jdelisle avatar jdelisle commented on May 22, 2024

I just tried it and I do get the correct path now: /usr/local/opt/firefoxpwa/bin/firefoxpwa.

Thank you for this quick answer and fix as well as for this great project!

from pwasforfirefox.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.