Giter Club home page Giter Club logo

Comments (7)

zepfietje avatar zepfietje commented on August 16, 2024 1

Hmm, formatting on Filament's side may confuse devs if they don't expect their stored data to be formatted after hydration.

The native browser input would probably give an unexpected result too (like #13123 (comment)).
I'm going to close this issue for now, but tagging @danharrin to see if he thinks we should reopen and implement a "fix" in Filament.

from filament.

github-actions avatar github-actions commented on August 16, 2024

Hey @RicLeP! We're sorry to hear that you've hit this issue. 💛

However, it looks like you forgot to fill in the reproduction repository URL. Can you edit your original post and then we'll look at your issue?

We need a public GitHub repository which contains a Laravel app with the minimal amount of Filament code to reproduce the problem. Please do not link to your actual project, what we need instead is a minimal reproduction in a fresh project without any unnecessary code. This means it doesn't matter if your real project is private / confidential, since we want a link to a separate, isolated reproduction. That would allow us to download it and review your bug much easier, so it can be fixed quicker. Please make sure to include a database seeder with everything we need to set the app up quickly.

from filament.

github-actions avatar github-actions commented on August 16, 2024

Thank you for providing reproduction steps! Reopening the issue now.

from filament.

RicLeP avatar RicLeP commented on August 16, 2024

Repository added: https://github.com/RicLeP/filament-datetime-bug

from filament.

zepfietje avatar zepfietje commented on August 16, 2024

I'm not sure if this should be treated as a Filament bug, or you should manually format the state to conform to the configured step after hydrating the field.

from filament.

RicLeP avatar RicLeP commented on August 16, 2024

I wasn't sure either. The error messages the browser gives are very confusing for anyone wanting to debug it, they've nothing to do with the data having the wrong values to work.

For me I see the issue being when external data has been imported, you don't know if it's in the right format. Or saving now() if left empty.

I agree that it can be resolved when hydrating but with combination of different data sources and the misleading errors (due to browsers more than Filament I think) I can see people being caught out.

Should inputs with minitrStep set hydrate correctly by default?

from filament.

RicLeP avatar RicLeP commented on August 16, 2024

Related issue - Textarea with numeric() set in a wizard. The user can enter commas, but if the field is on a prior wizard step when saving is throws a An invalid form control is not focusable. error in the browser. This stops the data being saved but shows no error or feedback to the user, just a cryptic message in the console.

from filament.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.