Giter Club home page Giter Club logo

Comments (3)

danharrin avatar danharrin commented on June 26, 2024 1

I would appreciate it if you investigated this issue and opened a PR yourself with your findings if possible.

from filament.

valentin-morice avatar valentin-morice commented on June 26, 2024

Adding a stream filter in the CanImportRecords trait, getUploadedFileStream method:

use League\Csv\CharsetConverter;

public function getUploadedFileStream(TemporaryUploadedFile $file) {

        CharsetConverter::register();

        $filePath = $file->getRealPath();

        if (config('filament.default_filesystem_disk') !== 's3') {
            $resource = fopen($filePath, mode: 'r');

            $filter = stream_filter_append(
                $resource,
                CharsetConverter::getFiltername('iso-8859-15', 'utf-8'),
                STREAM_FILTER_READ
            );

            return $resource;
        }
        
        // ...
}

makes the import work:

image

However, the input encoding would have to be set dynamically. This function doesn't seem to work, as of PHP8.1, to automatically detect encoding. Maybe a dropdown with possible encodings could be presented to the user instead?

from filament.

Rahmon avatar Rahmon commented on June 26, 2024

Hi @valentin-morice

I tested your approach and it worked as expected.

Maybe instead of a dropdown with possible encodings presented to the user, it could be an option in the Importer class with the expected charsets and using the function mb_detect_encoding to detect the most likely character encoding.

from filament.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.