Giter Club home page Giter Club logo

Comments (6)

ryangjchandler avatar ryangjchandler commented on May 13, 2024 2

@jamessessford Thanks for confirming. Was aware of the IDs, had it on my list to fix. Will open a PR shortly to sort this.

from filament.

danharrin avatar danharrin commented on May 13, 2024 1

@ryangjchandler what are you thinking? Prefix IDs with a random string?

That's going to be the simplest way of doing it - in some cases, you could end up with 3/4 matching IDs on a page so there needs to be some sort of prefix in place. It could even be simpler and prefix the name with the $context string...

$context works better since LW will regenerate random strings on refresh,

from filament.

jamessessford avatar jamessessford commented on May 13, 2024

Hi folks, I was able to reproduce this.

It seems the same ID's are being used inside the create modal and edit modal, then when clicking on the label in the edit modal, it's focusing the element in the create modal (which is presumably the first modal drawn so its element with the ID is used),

Cheers

from filament.

danharrin avatar danharrin commented on May 13, 2024

@ryangjchandler what are you thinking? Prefix IDs with a random string?

from filament.

ryangjchandler avatar ryangjchandler commented on May 13, 2024

@ryangjchandler what are you thinking? Prefix IDs with a random string?

That's going to be the simplest way of doing it - in some cases, you could end up with 3/4 matching IDs on a page so there needs to be some sort of prefix in place. It could even be simpler and prefix the name with the $context string...

from filament.

danharrin avatar danharrin commented on May 13, 2024

Solved by #158.

from filament.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.