Spatie Laravel Media Library Plugin - Error if using Closure on ->collection() about filament HOT 5 CLOSED

In #11863 you can add allCollections() to show media from all collections

from filament.

This was an unfortunate breaking change but it's for the best. It only happens when you have a typed $record arg. We made the change so we aren't eager loading media from collections we do not use.

You need to return null if the $record is null, so all images get eager loaded in.

Alternatively, $record->media()->first()?->collection_name looks like you don't even need collection() at all, it is just getting whatever collection is defined. It's also an N+1 query. Maybe remove it?

from filament.

This is exactly what i need. Show in a table all the records with his own media that can be “images” or “documents” (i’ve a fallback image for supported extension) or whatever. Mine is a media library where a model is related to a spatie model. This way i can reference that model anywhere in my project and a single media can be used on multiple other entities.

from filament.

Yeah, so you should be able to remove the collection() to load all media?

from filament.

If I remove the collection() method, the block of code in applyEagerLoading will default to filtering by 'default,' and then nothing will be returned as media because all of my media elements are either 'images' or 'documents.'

I think that the modifyMediaQuery should only be executed if a collection() is provided; otherwise, it will always default to 'default' and will not display anything as an image.

I understand that we are discussing a SpatieMediaLibraryImageColumn, so it should always be an 'image' or something similar, but I still display icons for other types of documents.

A possible solution could be to use $this->collection instead of $this->getCollection(). This is because the method will return "default" if nothing is passed to the ->collection() method, whereas $this->collection will be empty if nothing is passed, and then the Builder will not add any filter.

/** @phpstan-ignore-next-line */
$modifyMediaQuery = fn (Builder | Relation $query) => $query
    ->ordered()
    ->when(
        $this->collection,
        fn (Builder | Relation $query, string $collection) => $query->where(
            'collection_name',
            $collection,
        ),
    );

from filament.