manage file not found errors about node-dependencies-view HOT 5 CLOSED

Wait, what? So you're telling me that resolve-from actually checks a file for its existence? I thought it would just perform some string manipulation with pathnames. That would work, right? I think we can just remove resolve-from entirely and replace it with https://nodejs.org/api/path.html#path_path_resolve_paths

If you want to try that out and send a PR I will gladly accept it. Otherwise your solution will work too, but I really prefer to NOT check for file existence, that's useless filesystem bloat.

If you don't want to send a PR, show me at least a repo of yours with a missing file like that so I can use it for testing (as you can see, there are no unit tests in this project -- yes, I'm a horrible programmer).

from node-dependencies-view.

Thanks.

I just tried to replace resolve-from by path.resolve, however it does not produce the expected result.

Required modules do not get their file extensions appended, and are considered as different entities from the actual files (resulting in the same module being shown twice in two different places in the graph) 🤔 .

Do you see a solution for this? Perhaps that another approach is to be considered...

from node-dependencies-view.

I don't know why you replaced the , with a + 😛 but it is working now.

from node-dependencies-view.

Forget about it. You were right. It is not. I've broken everything.

(That's why you should always have unit tests.)

from node-dependencies-view.

Thanks 👍

from node-dependencies-view.