Giter Club home page Giter Club logo

Comments (6)

jmandel avatar jmandel commented on July 19, 2024

Thanks Rob! We don't currently build/host branches on IGs, although we have a feature in place to host branches of the main FHIR build (626ca7c).

It would be good to do something similar with IGs. Let me do a quick assessment to determine the level of effort for this -- but I think it should be pretty straightforward.

from auto-ig-builder.

robeastwood-agency avatar robeastwood-agency commented on July 19, 2024

Thank you very much Josh, that's great.

from auto-ig-builder.

jmandel avatar jmandel commented on July 19, 2024

Reading through your write-up in more detail: making this work from forks is a bit tricker than making it run from separate branches within your main repo. Just to understand the use case: how tied are you to using GH forks?

from auto-ig-builder.

jmandel avatar jmandel commented on July 19, 2024

The key question is where the output will be hosted for review. If we restricted auto-build to branches in the "main" repo, we could have URLs like:

https://build.fhir.org/ig/branches/:org/:repo/:branchname

... but if we auto-build forks, this would break down because multiple forks could use the same branch name, and would be competing for the same space on build.fhir.org.

On the other hand, if we asked fork authors to explicitly, independently set up their forks to auto-build, then we'd have URLs like:

https://build.fhir.org/ig/branches/:orgForForkingUser/:repoForForkingUser/:branchname

... which is more work for contributors, but avoids the ambiguity. Thoughts?

from auto-ig-builder.

robeastwood-agency avatar robeastwood-agency commented on July 19, 2024

Apologies for the delay in answering Josh. I am not altogether sure I have fully grasped the nuances you propose, so I hope this helps.

The "main" repo that we have forked from (the HL7 AU base IG) already does auto building and there is no talk about building from branches other than master. It is only that our forked copies will have our proposed work contained in various branches that we wish to have rendered via auto-building. Once these PRs are accepted it is all merged into master. So assuming that I understand correctly, the latter option of asking fork authors to explicitly, independently set up their forks to auto-build, seems OK. And I don't think that extra work is a problem.

However, it would be good to run this past some folk who are less noobish that me!

thank you

from auto-ig-builder.

jmandel avatar jmandel commented on July 19, 2024

Just a quick follow-up that this has been in place for a while now. You can navigate to your IG + /branches to see built content across branches.

from auto-ig-builder.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.