Giter Club home page Giter Club logo

Comments (5)

fhightower avatar fhightower commented on June 1, 2024 2

Thanks for finding and reporting this @Javiery3889 ! I believe I have fixed the problem, but let me know if you find other edge-cases.

from ioc-finder.

fhightower avatar fhightower commented on June 1, 2024 1

Thanks for reporting this @Javiery3889 ! And thank you for looking into the problem; that is really helpful (and most people don't do that)! I'll take a look and will hopefully have a fix soon.

from ioc-finder.

fhightower avatar fhightower commented on June 1, 2024

I've pushed an update to fix this issue. Thanks again for reporting! With the new implementation, there is one caveat (which I've noted in the readme):

A registry key path with a space in the final section (the part after the final \) will not be taken as part of the registry key. For example:

HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Console\ConsoleIME will be parsed as HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Console\ConsoleIME

and

HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Console\ConsoleIME foo... will be parsed as HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Console\ConsoleIME (notice that everything after the space in the last section is removed)

from ioc-finder.

Javiery3889 avatar Javiery3889 commented on June 1, 2024

Hi @fhightower just discovered another bug regarding registry keys with multiple whitespaces, the path gets truncated as well shown below on Python 3.6.7.

from ioc_finder import find_iocs
text = "HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\Image File Execution Options\notepad.exe"
iocs = find_iocs(text)
print(iocs['registry_key_paths'])
# output: 'HKLM\\SOFTWARE\\Microsoft\\Windows NT\\CurrentVersion\\Image'

However, I am unsure about the workaround this time, any advice? Thanks.

from ioc-finder.

fhightower avatar fhightower commented on June 1, 2024

Good catch. I'll take a look at that.

from ioc-finder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.