Giter Club home page Giter Club logo

Comments (6)

jplitza avatar jplitza commented on June 26, 2024

I feel like neither MAX nor CEIL is the right thing to use, because having a bunch of clients connected for some seconds because a tram rushed by isn't that interesting. Regrettably, rrdtool doesn't have a generic ROUND function as it seems, which would be more appropriate. But the best solution might be to clearly point (in a legend or title) out that these numbers are 1-hour-averages.

from ffmap-backend.

ecsv avatar ecsv commented on June 26, 2024

Thanks for the feedback.

To the rounding function: This can be implemented implement with existing rrdtool instructions because we only expect positive numbers (including zero) of client:

'CDEF:c=0.5,clients,ADDNAN,FLOOR'

from ffmap-backend.

jplitza avatar jplitza commented on June 26, 2024

Yes, of course. I probably should have slept more. Well then, I would prefer rounding over ceiling or flooring, but still vote for simply pointing out that these are rounded values. Any other opinions?

from ffmap-backend.

ecsv avatar ecsv commented on June 26, 2024

@simonwunderlich Please check these suggestions and discuss them with the people also having problems interpreting the graph

from ffmap-backend.

simonwunderlich avatar simonwunderlich commented on June 26, 2024

Thank you for bringing that up! My personal first thought was if the graph even shows clients, or if it is some kind of "mixed graph" which shows multiple information (clients, up/down speed, etc) at the same time. The fractions let me think that it must be throughput speeds, not clients that have been shown there, but that was obviously wrong. :)

So I definitely agree to only show integers only, not fractions/real numbers to make that clear. I think we don't need to add a lot of explanation text, but what we could do for clarification is to change the "up" and "down" to "router online" and "router offline".

Also, my personal opinion on round vs ceil vs floor would be ceiling. If you consider a router which had one client at some time, which would lead to an average of 0.1 for example, we would only see this with ceiling, and I think this would preferable.

I'll also bring this discussion to the attention of our group, maybe there are more comments.

Thanks again for taking care of that!

from ffmap-backend.

ecsv avatar ecsv commented on June 26, 2024

FFV/FFC stopped using the rrdtool for generating the graphs. Also no one else from the original persons who started the discussion contributed anything here. So I am closing it now

from ffmap-backend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.