Comments (6)
I feel like neither MAX nor CEIL is the right thing to use, because having a bunch of clients connected for some seconds because a tram rushed by isn't that interesting. Regrettably, rrdtool doesn't have a generic ROUND function as it seems, which would be more appropriate. But the best solution might be to clearly point (in a legend or title) out that these numbers are 1-hour-averages.
from ffmap-backend.
Thanks for the feedback.
To the rounding function: This can be implemented implement with existing rrdtool instructions because we only expect positive numbers (including zero) of client:
'CDEF:c=0.5,clients,ADDNAN,FLOOR'
from ffmap-backend.
Yes, of course. I probably should have slept more. Well then, I would prefer rounding over ceiling or flooring, but still vote for simply pointing out that these are rounded values. Any other opinions?
from ffmap-backend.
@simonwunderlich Please check these suggestions and discuss them with the people also having problems interpreting the graph
from ffmap-backend.
Thank you for bringing that up! My personal first thought was if the graph even shows clients, or if it is some kind of "mixed graph" which shows multiple information (clients, up/down speed, etc) at the same time. The fractions let me think that it must be throughput speeds, not clients that have been shown there, but that was obviously wrong. :)
So I definitely agree to only show integers only, not fractions/real numbers to make that clear. I think we don't need to add a lot of explanation text, but what we could do for clarification is to change the "up" and "down" to "router online" and "router offline".
Also, my personal opinion on round vs ceil vs floor would be ceiling. If you consider a router which had one client at some time, which would lead to an average of 0.1 for example, we would only see this with ceiling, and I think this would preferable.
I'll also bring this discussion to the attention of our group, maybe there are more comments.
Thanks again for taking care of that!
from ffmap-backend.
FFV/FFC stopped using the rrdtool for generating the graphs. Also no one else from the original persons who started the discussion contributed anything here. So I am closing it now
from ffmap-backend.
Related Issues (20)
- Preserve roaming when obscure clients HOT 1
- RRD.py vs. rrd.py HOT 6
- check forked repos HOT 1
- add socket support (alfred) HOT 4
- duplicate node (nbsp-router)
- create outdir and nodes.json when it does not exist
- make backend.py a daemon HOT 1
- Blacklist for some nodes or coordinates for the map HOT 4
- ZeroDivisionError Exception HOT 1
- Missing geo.latitude produces errors HOT 1
- Collect site code HOT 2
- Migrate nodes.json from format 1 to 2
- Backend Error HOT 4
- graph.json undocumented HOT 2
- Add branch with bin substitutes, so the branch works on external machines HOT 1
- Make output filterable using libjq
- running as unprivileged user doesn't work as documented HOT 5
- support node down areas for graphs over longer timespan HOT 5
- y-labels unreadable on node with many clients HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ffmap-backend.