Feature request: Add DRC parameter to FFAudioSource() about ffms2 HOT 15 CLOSED

Thanks for the fast implementation of avs+ properties, @myrsloik.

Can the same be done with drc_scale patch/arg?

I know you are aware of this doom9 post. StvG builds have reverted back commits and they are using the old way of how ffms2 works, and that's why his other patches cannot be incorporated, right? Cannot something be done to eliminate the regression of the upstream builds compared to StvG builds? From the seeking tests I saw in doom9 (I tested with few other samples too) between the StvG builds and the official one, StvG builds are at least good as the official one. It would be great if the upstream builds are at least good as those custom builds.

from ffms2.

Nope, drc would require breaking the ABI unless I think of something really clever and I don't think it's worth it. Are there any other formats with optional information in the bitstream that may or may not be applied and the standard says the user should be able to choose? I can't think of any.

from ffms2.

Thanks for your time.

from ffms2.

I am however experimenting with it in BestAudioSource so maybe try that once it's updated

from ffms2.

Tried BestAudioSource (50f514c, compiled with ffmpeg 4.4) but drc_scale does nothing - set it to 0/1/3 gives identical output.

from ffms2.

Try now, I got misled by the horribly broken d9 patches

from ffms2.

Implemented in ffms2 as well. No actual testing done yet.

from ffms2.

Tried 0461d80 but the output is still identical for drc_scale=0/1/3.
Btw drc_scale=0/1/3 is ok when using ffms2 ver from doom9.

from ffms2.

Are you sure you're testing with an appropriate file? I used comp.exe with bas and got different results. Also audibly different.

from ffms2.

Tested with this sample and used avs+.
https://imgbox.com/g/3um0zPkG1z - check these images with waveform. Also used ffmpeg to load the avs script and save the audio as wav - wav files from bestaudio drc_scale=x always have identical hash but these from ffms2 with different drc_scale values have different hashes.

Tried upstream ffms2 (0753759) - it's ok. Thanks.

Btw does ffms2 audio have lower precision when decoding compared to bestaudio/ffmpeg? Asking because you can see from the images in the above gallery (ffms2 drc_scale 0 and bestaudio drc_scale x) that there is a difference and ffms2 output looks like having rounding error? bestaudio drc_scale x matches the output of ffmpeg -drc_scale 0 -i ...

from ffms2.

Now I know why, I forgot to pass on the new options to BAS when using it from Avisynth but not VS. Try again and be amazed... maybe.

from ffms2.

Btw, the decode precision is the same and any differences are more likely to be cause by seeking or something similar in FFMS2. I guess...

from ffms2.

BAS is ok now too. Thanks.

Btw, the decode precision is the same and any differences are more likely to be cause by seeking or something similar in FFMS2. I guess...

LWLibavAudioSource gives identical output to FFAudioSource for this frame. Should BAS/ffmpeg result be considered as more precise result than LSMASHSource/FFMS2 in this case?

from ffms2.

Yes, BAS and FFmpeg are definitely the reference here since both do simple linear decoding of the whole file. It's still odd that LSMASHSource/FFMS2 has exactly the same deviation. If anything I'd expect them to be slightly different.

from ffms2.

The LSMASHSource/FFMS2 output is not only visibly identical (with waveform) but the hashes match too.
Anyway, thanks for the info.

from ffms2.