Comments (3)
Hi! Thanks so much for your report. The bug here is pretty embarrassing in how it got overlooked. The diff here is just inserting the correct .filter
call in the sole-element case; I'd managed to forget to do that in both count_ones
and count_zeros
, and never noticed.
I've published 0.10.1
to https://crates.io/crates/bitvec; you should be able to get the fix with a cargo update
command.
from bitvec.
@geq1t, I've been looking through the git history of this bug and I want to take a minute to say how extremely thankful I am not only for opening this issue but for the information you provided. The test case you gave reproduced, and your sentence,
Interestingly, it does work across when operating across byte boundaries.
Told me exactly what the error was while I was reading the email, before I'd even opened my editor. This was a great report; thanks for using bitvec
and I hope it's working well for you!
from bitvec.
Thanks for fixing this so quickly! I'm glad the bug report was useful. I'll give it a try again next week, but other duties call right now.
from bitvec.
Related Issues (20)
- `copy_within` panics on empty range
- `bitarr!` macro link incorrect
- Implement `BitStore` for signed integer types
- impl `TryFrom<BitVec>` for `BitArray`
- How to convert bitvec to slice? HOT 1
- Build for STM32 (no_std, thumbv7m-none-eabi) - no global memory allocator HOT 1
- Regarding the safety of `chunks_mut(...).remove_alias()` HOT 1
- `BitSlice::shift_start` and `BitSlice::shift_end` argument bounds incorrectly documented
- Incorrect handling of end index in BitVec::extend_from_within
- Implement `Send` for `BitValIter`
- How to "not" an entire `BitVec` in place? HOT 1
- Example of zero-initialized BitVec?
- Cargo check failed with error: could not compile `bitvec` (lib) HOT 2
- crate doesnt compile on arduino HOT 1
- crate tests do not compile with MSRV 1.56 due to dependencies dropping support for that version
- `bits!` macro causes "cannot find type `Lsb0` in this scope"
- Optimise creating zeroed vectors
- Conversion between similar crates HOT 1
- Integer to pointer cast
- BitVec::from_iter has unexpected len
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bitvec.