Sending buffers fails over wrtc sometimes about simple-peer HOT 4 CLOSED

My pull request is here: #61

from simple-peer.

What version of node? Please run node --version. This sounds like a bug in wrtc.

from simple-peer.

I'm using node 5.5.0.

Maybe this is just mincing words, but I'm not sure if I would say that this is a bug in wrtc, since it doesn't claim to allow Buffers (see node-webrtc/node-webrtc#103).

In node 5.5, it looks like Buffers are considered to be typed arrays by is-typedarray. I'm not sure if that's true in other versions of node; I'll check it out.

paul ~/projects/swarmhub master $ node --version
v5.5.0
paul ~/projects/swarmhub master $ node
> require('is-typedarray')(Buffer([1,2]))
true

from simple-peer.

Buffer is a subclass of Uint8Array since iojs v3 and node v4. So, for any Buffer buf, this should be true: buf instanceof Uint8Array. That's why I think it's ultimately a bug in wrtc.

That issue about wrtc not supporting buffers is old, from the time before Buffer was implemented as a subclass of Uint8Array.

from simple-peer.