optionalDependency on wrtc is unwanted for web projects about simple-peer HOT 3 CLOSED

Agreed here (except about peerDependencies, those are just as evil as optionalDependencies). This is an unwanted feature except when I want node support and is highly likely to fail (I still haven't got the build to actually work yet, which fails the entire package install). What about a separate package for node support? optionalDependencies are just not reliable.

An alternative might be to pass wrtc in as a parameter:

var SimplePeer = require('simple-peer')

var peer1 = new SimplePeer({ initiator: true, webrtc: require('wrtc') })
var peer2 = new SimplePeer({ webrtc: require('wrtc') })

Then in the readme just state that if you want node support, you should pass in opts.webrtc yourself. This also makes the backend implementation swappable so that if something better comes along (like a pure js version) it'll be easy to switch.

from simple-peer.

Version 5.0.0 removes the wrtc dependency. Instead, you must now pass it in like:

var SimplePeer = require('simple-peer')
var wrtc = require('wrtc')

var peer1 = new SimplePeer({ initiator: true, wrtc: wrtc })
var peer2 = new SimplePeer({ wrtc: wrtc })

from simple-peer.

👍

from simple-peer.