Comments (11)
Yes, it is a messy issue tbh. If you want to read more about the whole problem microsoft/TypeScript#16577
For now, I've added a small task to add the .js extensions so this should work good with the latest version I've just published v0.16.0
from lit-redux-router.
Thanks for the quick fix!
from lit-redux-router.
Sorry to bother you again, but it seems there are still 2 issues:
import { unsafeHTML } from 'lit-html/directives/unsafe-html';
in route.ts is not adding the extension.
And also exports should specify it:
export { navigate } from './lib/actions';
in lit-redux-router.ts
If I fix those 2 locally, it works fine.
from lit-redux-router.
@giejay sorry you are right, it's not working for the non default imports, sorry I'll have a look at this again
from lit-redux-router.
@giejay please try again with v0.16.1
from lit-redux-router.
@fernandopasik So the export in lit-redux-router seems to be fixed now but the import in route.ts is still missing an extension:
import { unsafeHTML } from 'lit-html/directives/unsafe-html';
from lit-redux-router.
Thank you for spotting it. This one is a different one, because the others were relative imports.
I'll resolve the module ones that resolve inside of it.
from lit-redux-router.
Hi @fernandopasik, any update?
from lit-redux-router.
@giejay after more thinking on this I switched to using .js extensions in typescript. Everything is out in the 0.17.0 version
from lit-redux-router.
It should be fixed now. If there's any remaining issue please comment again.
from lit-redux-router.
Hi, checked it yesterday and all is working fine now! Thanks
from lit-redux-router.
Related Issues (20)
- Add `module` property in package.json HOT 12
- Ability to conditionally pre-redirect HOT 3
- Update Documentation to show store setup HOT 2
- route not working. HOT 1
- path routing 404 on client side HOT 3
- JS error in Edge v44 HOT 4
- allow path to assume base href HOT 3
- Suggestion - enable `scrollDisable` by default HOT 3
- how to get query params HOT 2
- Component reloads on every state change HOT 5
- Lazy Loaded components are never rendered
- Usage with redux-toolkit? HOT 3
- lit-route lit-plugin typing HOT 4
- Upgrade to latest version / distribution of `Lit@2` HOT 9
- The demo folder is also published to NPM which causes issues when building HOT 1
- Allow the use of sub-routers HOT 1
- Add authentication property HOT 2
- add option to disable / opt-out of Shadow DOM to support global CSS libraries HOT 8
- Using subroutes inside of components (with shadowRoot) HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lit-redux-router.