Giter Club home page Giter Club logo

Comments (8)

armandobelardo avatar armandobelardo commented on August 18, 2024

@maxdeichmann could you share your Fern configuration (e.g. the contents of generators.yml as well as the version within fern.config.json)? We should only default to this if we cannot determine the package being created

from fern.

maxdeichmann avatar maxdeichmann commented on August 18, 2024

Fern config: https://github.com/langfuse/langfuse/blob/main/fern/fern.config.json
Python Generator: https://github.com/langfuse/langfuse/blob/main/fern/apis/server/generators.yml#L13

from fern.

maxdeichmann avatar maxdeichmann commented on August 18, 2024

Thanks for looking into this!

from fern.

armandobelardo avatar armandobelardo commented on August 18, 2024

Ah I see! Yeah this is confusing!

Since you do local publishing and we don't control the pyproject.toml there (or the other project files), we don't know the project name and so we use "project" to try to pull it in from elsewhere, and you can always manually update it and add the file to your .fernignore if necessary (structured similar to a .gitignore, Fern won't touch files listed there on regeneration).

I'll go ahead and remove this from local publishing!

@maxdeichmann could I ask why you're not leveraging github output mode to PR to your repo automatically? https://buildwithfern.com/learn/sdks/guides/github-bot#pull-request-mode

from fern.

maxdeichmann avatar maxdeichmann commented on August 18, 2024

@armandobelardo thanks a lot for the hint to .fernignore. Can you point me to docs on how to use it to exclude https://github.com/langfuse/langfuse-python/blob/63c0fa497dc04d295363158b0ff1be382edb3f10/langfuse/api/version.py
?
I cannot find it in the docs.

I think we do not use the github feature as it did not exist when we set up fern initially.

from fern.

armandobelardo avatar armandobelardo commented on August 18, 2024

It's not a well documented feature since there are some downsides! So we tend to not promote it and only suggest it when necessary
Since you're running local generation it's also a touch less relevant anyway

I've released a fix for this in version 1.1.0-rc1 here's the change: #3320
Note that if you are not on 1.0.0, there are breaking configuration changes, to continue with the existing configuration you have today, you must follow the config in the changelog: https://github.com/fern-api/fern/blob/main/generators/python/sdk/CHANGELOG.md#100---2024-04-02

from fern.

maxdeichmann avatar maxdeichmann commented on August 18, 2024

Hi, so i assume i dont have to do anything once the fix is live?

from fern.

armandobelardo avatar armandobelardo commented on August 18, 2024

That's correct, you can upgrade your generator now actually! It will remove the bad files, and you should be set!

from fern.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.