Comments (7)
ferd
commented on May 10, 2024
1
I'm a bit surprised yeah. This worked on OTP-26-RC3, and the full pattern still works outside of it on OTP-26 when using the matching function to make it work:
2> recon_trace:calls({lists, seq, return_trace}, 10).
2
3> lists:seq(1,10).
[1,2,3,4,5,6,7,8,9,10]
4> recon_trace:calls({lists, seq, fun(_) -> return_trace() end}, 10).
2
5> lists:seq(1,10).
13:9:53.284312 <0.164.0> lists:seq(1, 10)
[1,2,3,4,5,6,7,8,9,10]
13:9:53.284648 <0.164.0> lists:seq/2 --> [1,2,3,4,5,6,7,8,9,10]
The translation there is just a shortcut toward recon_trace:calls({lists, seq, [{'_', [], [{return_trace}]}]}, 10). and that's what no longer works.
I think this might be a break in Erlang/OTP itself, I'll see if I can follow up with folks from the OTP team.
from recon.
ferd
commented on May 10, 2024
1
Yeah for the time being I'll stop investigating here and track the OTP repo's bug, seems related.
from recon.
ferd
commented on May 10, 2024
Oh actually odd thing: they are fully equivalent. It's just the first call that fails:
1> recon_trace:calls({lists, seq, return_trace}, 10).
2
2> lists:seq(1,10).
[1,2,3,4,5,6,7,8,9,10]
3> lists:seq(1,10).
13:29:41.882057 <0.164.0> lists:seq(1, 10)
[1,2,3,4,5,6,7,8,9,10]
13:29:41.882527 <0.164.0> lists:seq/2 --> [1,2,3,4,5,6,7,8,9,10]
So the bug is really that the first invocation to a trace fails somehow.
from recon.
ferd
commented on May 10, 2024
Oh interesting, I decomposed the calls and it works fine with the built-in functions, so it is a recon bug. That's odd.
1> Tracer = spawn(fun F() -> receive X -> io:format("received ~p~n", [X]) end, F() end).
<0.166.0>
2> erlang:trace_pattern({lists, seq, '_'}, [{'_',[],[{return_trace}]}], [global]).
2
3> erlang:trace(all, true, [call, timestamp, {tracer,Tracer}, arity]).
90
4> lists:seq(1,10).
received {trace_ts,<0.164.0>,call,{lists,seq,2},{1685,22325,12420}}
[1,2,3,4,5,6,7,8,9,10]
received {trace_ts,<0.164.0>,return_from,
{lists,seq,2},
[1,2,3,4,5,6,7,8,9,10],
{1685,22325,12426}}
I'm now thinking this is a problem with the rebar3 shell -- there were a lot of changes around that, and the hack is on rebar3's side so I'll look into it.
from recon.
ferd
commented on May 10, 2024
Here's the diff I ran:
diff --git a/src/recon_trace.erl b/src/recon_trace.erl
index 975f536..2d78009 100644
--- a/src/recon_trace.erl
+++ b/src/recon_trace.erl
@@ -354,6 +354,7 @@ count_tracer(0) ->
count_tracer(N) ->
receive
Msg ->
+ io:format(standard_error, "tracer received ~p~n", [Msg]),
recon_trace_formatter ! Msg,
count_tracer(N-1)
end.
@@ -393,6 +394,7 @@ formatter(Tracer, IOServer, FormatterFun) ->
{'EXIT', Tracer, Reason} ->
exit(Reason);
TraceMsg ->
+ io:format(standard_error, "~n Fake: ~p~n", [FormatterFun(TraceMsg)]),
io:format(IOServer, FormatterFun(TraceMsg), []),
formatter(Tracer, IOServer, FormatterFun)
end.And how I invoke it:
→ rebar3 shell
===> Verifying dependencies...
===> Analyzing applications...
===> Compiling recon
Erlang/OTP 26 [erts-14.0] [source] [64-bit] [smp:2:2] [ds:2:2:10] [async-threads:1] [jit:ns]
Eshell V14.0 (press Ctrl+G to abort, type help(). for help)
1> recon_trace:calls({lists, seq, [{'_',[],[{return_trace}]}]}, 10).
2
2> lists:seq(1,9).
tracer received {trace,<0.171.0>,call,{lists,seq,[1,9]}}
tracer received {trace,<0.171.0>,return_from,
{lists,seq,2},
[1,2,3,4,5,6,7,8,9]}
[1,2,3,4,5,6,7,8,9]
3>
Fake: [10,"14",58,"54",58,48,57,46,49,51,55,50,51,51,32,"<0.171.0>",32,
"lists",58,"seq",
[40,[["1"],", ",["9"]],41],
10]
3>
Fake: [10,"14",58,"54",58,48,57,46,49,53,49,49,57,54,32,"<0.171.0>",32,
"lists",58,"seq",47,"2",32,45,45,62,32,
[[91,
["1",44,"2",44,"3",44,"4",44,"5",44,"6",44,"7",44,"8",44,"9"],
93]],
10]
3> lists:seq(1,10).tracer received {trace,<0.171.0>,call,{lists,seq,[1,10]}}
tracer received {trace,<0.171.0>,return_from,
{lists,seq,2},
[1,2,3,4,5,6,7,8,9,10]}
Fake: [10,"14",58,"54",58,49,50,46,52,54,57,53,54,51,32,"<0.171.0>",32,
"lists",58,"seq",
[40,[["1"],", ",["10"]],41],
10]
14:54:12.469850 <0.171.0> lists:seq(1, 10)
[1,2,3,4,5,6,7,8,9,10]
Fake: [10,"14",58,"54",58,49,50,46,52,55,48,51,53,52,32,"<0.171.0>",32,
"lists",58,"seq",47,"2",32,45,45,62,32,
[[91,
["1",44,"2",44,"3",44,"4",44,"5",44,"6",44,"7",44,"8",44,"9",44,
"10"],
93]],
10]
14:54:12.470583 <0.171.0> lists:seq/2 --> [1,2,3,4,5,6,7,8,9,10]
Beats me why, but the second loop invocation works and gets the data out, but the first batch of call never does (even though it works with standard_error)
It's like until that formatter loop returns once, everything is hung.
from recon.
ferd
commented on May 10, 2024
Might be related to erlang/otp#7263
from recon.
lhoguin
commented on May 10, 2024
This was seen outside of Rebar first, in a RabbitMQ shell, for what it's worth.
from recon.
Related Issues (20)
- Please create a new release HOT 4
- recon_alloc memory function returns memory used more than physical memory of the VM HOT 1
- `recon:node_stats` - Issue in number of reductions HOT 1
- How to trace recursive calls ? HOT 7
- Request to release 2.5.5 HOT 1
- Would atom table dumping be useful for recon? HOT 4
- difficulties installing recon HOT 11
- New relase with records tracing HOT 5
- Dialyzer warning for overlapping domains HOT 7
- Map filtering breaks some output
- recon_alloc fails on OTP 23 HOT 2
- recon_trace:calls for remote node HOT 1
- Crash on recon_alloc:memory(used) on OTP 23.0 HOT 3
- Move from Travis CI to GitHub Actions? HOT 1
- Newbie question HOT 1
- Elixir Kernel function cannot be traced but erlang kernel HOT 6
- Crash using `binary_memory` on a dead process
- app_deps.erl enhancements HOT 2
- recon:port_info/1 errors with OTP 23.0 and later when Creation > 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from recon.