Giter Club home page Giter Club logo

Comments (7)

AmauryD avatar AmauryD commented on June 11, 2024 1

I already began to work on this when i made this issue. It works but i need to repair the CI and maybe some tests (I don't remember it was 3 months ago). It can be installed using @triptyk/ember-simple-auth-token package.
Here's the repo: https://github.com/AmauryD/ember-simple-auth-token

from ember-simple-auth-token.

fenichelar avatar fenichelar commented on June 11, 2024 1

A major overhaul is in the works including:

  • Support for ember@4 and ember@5
  • V2 format

from ember-simple-auth-token.

SanderKnauff avatar SanderKnauff commented on June 11, 2024

@fenichelar apologies for the ping.

This addon seems to be incompatible with the lastest version of Ember 5 and ember-simple-auth.
There does not seem to have been a lot of activity recently in this respository. If there are any PRs opened to solve the compatibility issues, would you mind taking a look at them and merging them?

We are relying on this addon at my work and it is blocking us from upgrading to Ember 5. I wouldn't mind putting in some work to get it compatible, but I would like to know if contributions will be accepted before putting in the effort. 😅

from ember-simple-auth-token.

SanderKnauff avatar SanderKnauff commented on June 11, 2024

I already began to work on this when i made this issue. It works but i need to repair the CI and maybe some tests (I don't remember it was 3 months ago). It can be installed using @triptyk/ember-simple-auth-token package. Here's the repo: https://github.com/AmauryD/ember-simple-auth-token

Oh nice! With a bit of luck (and fixes for the tests) this could be merged upstream!

from ember-simple-auth-token.

AmauryD avatar AmauryD commented on June 11, 2024

Tracked by #334.
The tests are OK. Still need to investigate fastboot compatibility. I removed it 3 months ago because it was not working 😅 .

from ember-simple-auth-token.

AmauryD avatar AmauryD commented on June 11, 2024

Everything is kinda OK. I'm waiting for a feedback of @fenichelar before spending more time on this.
Only the embroider-optimized scenario is failing because of a bug with fastboot. Should be fixed upstream soon.

from ember-simple-auth-token.

AmauryD avatar AmauryD commented on June 11, 2024

A major overhaul is in the works including:

  • Support for ember@4 and ember@5
  • V2 format

Does this make this PR #334 obsolete ?

from ember-simple-auth-token.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.