Recognize test tokens without requiring a string literal about testify HOT 11 CLOSED

Hello! I'm sorry for taking so long to respond. I'll take a look into it and come back with an answer

from testify.

Hey @felixjb, thanks for looking into it. If the parser does have access to __filename and identifier.name, that sounds like it could be a perfect fit for our use case.

I probably won't have time until at least the weekend, but if I do start working on something, I'll let you know.

I don't think it's possible to evaluate a variable or template string to get a test name to execute te command on the terminal

That makes perfect sense. I just noticed that testify ultimately uses mocha's fgrep to specify which tests to run, so I can see why it'd need access to the fully evaluated description string.

from testify.

Hello @briancavalier

Just letting you know that I haven't forgotten this. I am trying to make time to work on it but I haven't gotten any yet.

from testify.

Hey @felixjb, I really appreciate all your research and communication on this. It's a bummer for now, but I completely understand. I'll look forward to a future version that uses those new VSCode features 😄

Thanks again for looking into it and for testify!

from testify.

I'd be happy to submit a PR if you decide this is a reasonable feature to add, @felixjb.

from testify.

Hi @briancavalier , here's what I found:

During transpilation I don't think it's possible to evaluate a variable or template string to get a test name to execute te command on the terminal. However, apparently, the __filename and identifier.name are things that could be available to the parser during transpilation.

I'll try to work on it during this week but probably will have more time during next week.

Feel free to open a PR if you feel comfortable enough!

from testify.

Thanks for the update, @felixjb

from testify.

@briancavalier I just found out that the VSCode API has now some new features regarding testing. I think I am going to spend some time learning how to use them. Maybe we'll be able to do better with this feature, who knows.

from testify.

Sounds good, @felixjb

from testify.

Hello @briancavalier

After some research and testing I got to the conclusion that this feature cannot be implemented, at least not without some major changes in the project.

Quick recap for anyone who comes looking into this the future:

Testify, as it is now (version 1.9.0), uses Babel parser to parse the source code and find any tokens related to test frameworks, like describe and test. Then, with the location of these tokens in the file and the value of the title argument of these test function calls, which is a StringLiteral, it opens a new terminal and sends a command to execute the test with the local test framework. This command filters the tests in the codebase by using an argument that takes the title of the test.

During the parsing of the file, Babel, as far as I know, cannot evaluate a variable, like __filename, and return its value. It also cannot evaluate a TemplateString. Without a test name, Testify cannot execute the command to run that specific test.

Now for the good news:

VSCode release a native API for working with tests and I think there are some good opportunities there. However, this may require some rework in our project, which I am willing to do, but will take some time. Until then, feel free to reach out! Maybe I'll make more use of the discussions section on this repo.

from testify.

You're welcome! And you're always welcome to open new issues and pull requests!

from testify.