Wrong `UsersShowParams` interface about twitter-api-client HOT 8 CLOSED

Hi @iliran11
Yeah, so it's an unfortunate occasion because both parameters are flagged as required but in the description, it actually says "Either an id or screen_name is required for this method".

So it means that you're supposed to provide either and id or a screen_name parameter.
But in the twitter-api-spec.yml, these are both set to required, which is what the UsersShowParams interface is based on.

There's a way to make a type in TypeScript, that satisfies the constraint that either one of them is provided, but it becomes hard to infer when this type should be used according to the Twitter Docs. And the generators don't yet support this concept, so it'll need to be implemented.

I think it's a great feature for the future, but for now, I think the best solution is to simply make them both optional.
This does allow the consumer to call this endpoint with none of them provided, but if so, an error will be thrown from the Twitter API.

from twitter-api-client.

@iliran11 Yes, totally!
I sent you an invite.

from twitter-api-client.

Hi @lcswillems
Nice catch - thanks for creating an issue!

Will take care of this asap 👍

from twitter-api-client.

This task is up for grabs during Hacktoberfest 🙌

If you want to work on this task, please claim it here in the comments.
Feel free to ask any questions here as well 😊

from twitter-api-client.

@silind, sorry having been direct in my issue, I was coding and discovered this bug so I quickly filled it.
I would like to thank you a lot for your library! It made me save a lot of time with your typings :)

from twitter-api-client.

Hey @lcswillems @silind . Not sure I understood the bug.
On twitter docs, it says the same thing as in the interface:
https://developer.twitter.com/en/docs/twitter-api/v1/accounts-and-users/follow-search-get-users/api-reference/get-users-show

$ curl --request GET 
    --url 'https://api.twitter.com/1.1/users/show.json?screen_name=twitterdev' 
    --header 'authorization: Bearer <bearer>'

Can you elaborate more?

from twitter-api-client.

Got it. I can take it too.
@silind, can you make me a collaborator so I can open a branch on this repository? Gonna be more convenient than working on a fork. I'll open PR against the development branch.

from twitter-api-client.

Fixed in v. 1.0.2.

from twitter-api-client.