Giter Club home page Giter Club logo

Comments (8)

fede87 avatar fede87 commented on August 18, 2024 1

@nestoleh I'm going to release it today, I've also added a couple of features to change text and progress bar colors.

from statusbaralert.

fede87 avatar fede87 commented on August 18, 2024

Hi, thanks for the report.
I have tested with android 7 on emulator, no issue found, can you gave me more details?
Are you providing the alert color with the function withAlertColor(color) on the builder object?
You can achieve transparent effect providing same color used in the theme for the status bar.

from statusbaralert.

nestoleh avatar nestoleh commented on August 18, 2024

Hi, I think @muhammadnomany25 meant status bar text and icons color, not the background. I have the same behavior on Android 10 (Xiaomi Mi Mix 3). Text of toolbar always white after StatusBarAlert showing and hiding, even if it was dark before and set as dark for activity theme.

from statusbaralert.

nestoleh avatar nestoleh commented on August 18, 2024

I added a pull request #5 to keep UI visibility flags, that will help to keep the status bar content color, @fede87 can you please look closer at it?

from statusbaralert.

fede87 avatar fede87 commented on August 18, 2024

Thanks @nestoleh for your contribution, I tried your changes but unfortunately if the alert view is shown when the status is not in low profile mode, when the alert view is going to be hidden the status bar will not reset its status to normal.
If you are looking to keep the status bar in the previous state if you show the alert view and the status bar is in low profile or immersive mode yet, the flag should be cached before showing the alert and reset after the hide animation. I will work on it in a further release.

from statusbaralert.

nestoleh avatar nestoleh commented on August 18, 2024

Hi @fede87, thanks for the response. It was my bad, I tested these changes on a Xiaomi device, and looks like MIUI doesn't work correctly with low profile mode (status bar never changed in low profile). Looks like I know how to fix this, we just need to remove the "low profile" flag on alert hide. I added new pull request #6 with these changes and tested it on the real device and emulators, for me it works correctly.

from statusbaralert.

fede87 avatar fede87 commented on August 18, 2024

Thanks @nestoleh again for your contribution and your quick fix!
I've tested and merged your pull request.

from statusbaralert.

nestoleh avatar nestoleh commented on August 18, 2024

Great! Are you planning a new release in the near future?

from statusbaralert.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.