Comments (12)
Sounds like something has changed on the Heroku platform. Is someone following their changes announcements?
from webpack-rails-buildpack.
Just to provide some information this fork of you build pack works https://github.com/booqable/webpack-rails-buildpack, I'm not sure which commits resolve the issue however.
from webpack-rails-buildpack.
The diff is small - master...booqable:master
The problem might be due to you keeping webpack
as a dependencies
entry in the packages.jon, not under devDependiencies
. Can you confirm that?
from webpack-rails-buildpack.
Thanks it is in fact under dependencies and not devDependencies. I thought it would be a dependency and not a dev dependency however may have misunderstood. perhaps this could be clearer in the readme, it seems that this did not matter earlier on the week on heroku but now does.
from webpack-rails-buildpack.
I became aware of this gotcha only now, sorry. And it's curious that it worked before.
Anyway, can you confirm that it's working with that change?
I'll put a note in the README to save other (and my future self) to get confused by this again.
from webpack-rails-buildpack.
Im currently using a fork where all dependencies are being installed and that works. I will try moving web pack into devdependencies and switching back next week and let you know.
from webpack-rails-buildpack.
Ok, thanks. But I'll leave out the note until this hunch of mine is confirmed. Definitely interested to hear if that change has this effect.
from webpack-rails-buildpack.
Ok, I have the same problem with my app. I'm gonna pull the commit from booqable.
from webpack-rails-buildpack.
Assuming cherry-picking 67cdc01 solved the problem. Please tell me if this solves the error @bitscraps, if you get a chance.
from webpack-rails-buildpack.
Hi @febeling / @bitscraps
I had the same issue and adding the --only=dev
to npm install
solved the issue for me. This is my bin/compile
diff
from webpack-rails-buildpack.
@roshiro that's the exact change I applied as well. Thanks for confirming that, it's very helpful.
from webpack-rails-buildpack.
With @roshiro's confirmation I'm closing this now. Please reopen in case.
from webpack-rails-buildpack.
Related Issues (12)
- Getting `Can't find our webpack executable at` error HOT 2
- Previous build not restored from cache, potentially causing 404s HOT 4
- NPM and Yarn Slapfight HOT 3
- Issue in first installation HOT 2
- Build failures installing bundler due to bundler 2.0 release
- Could not find bundler? HOT 14
- Make bundler version a range <2
- Bundler conflicts with ruby-2.6.1/bin/bundle HOT 2
- Deployment failure with Ruby 2.1.6
- nodejs webpack doesn't detect package.json file HOT 2
- Error in webpack compile step does not fail the deploy HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webpack-rails-buildpack.