Giter Club home page Giter Club logo

Comments (12)

febeling avatar febeling commented on May 24, 2024

Sounds like something has changed on the Heroku platform. Is someone following their changes announcements?

from webpack-rails-buildpack.

bitscraps avatar bitscraps commented on May 24, 2024

Just to provide some information this fork of you build pack works https://github.com/booqable/webpack-rails-buildpack, I'm not sure which commits resolve the issue however.

from webpack-rails-buildpack.

febeling avatar febeling commented on May 24, 2024

The diff is small - master...booqable:master

The problem might be due to you keeping webpack as a dependencies entry in the packages.jon, not under devDependiencies. Can you confirm that?

from webpack-rails-buildpack.

bitscraps avatar bitscraps commented on May 24, 2024

Thanks it is in fact under dependencies and not devDependencies. I thought it would be a dependency and not a dev dependency however may have misunderstood. perhaps this could be clearer in the readme, it seems that this did not matter earlier on the week on heroku but now does.

from webpack-rails-buildpack.

febeling avatar febeling commented on May 24, 2024

I became aware of this gotcha only now, sorry. And it's curious that it worked before.

Anyway, can you confirm that it's working with that change?

I'll put a note in the README to save other (and my future self) to get confused by this again.

from webpack-rails-buildpack.

bitscraps avatar bitscraps commented on May 24, 2024

Im currently using a fork where all dependencies are being installed and that works. I will try moving web pack into devdependencies and switching back next week and let you know.

from webpack-rails-buildpack.

febeling avatar febeling commented on May 24, 2024

Ok, thanks. But I'll leave out the note until this hunch of mine is confirmed. Definitely interested to hear if that change has this effect.

from webpack-rails-buildpack.

febeling avatar febeling commented on May 24, 2024

Ok, I have the same problem with my app. I'm gonna pull the commit from booqable.

from webpack-rails-buildpack.

febeling avatar febeling commented on May 24, 2024

Assuming cherry-picking 67cdc01 solved the problem. Please tell me if this solves the error @bitscraps, if you get a chance.

from webpack-rails-buildpack.

roshiro avatar roshiro commented on May 24, 2024

Hi @febeling / @bitscraps

I had the same issue and adding the --only=dev to npm install solved the issue for me. This is my bin/compile diff

from webpack-rails-buildpack.

febeling avatar febeling commented on May 24, 2024

@roshiro that's the exact change I applied as well. Thanks for confirming that, it's very helpful.

from webpack-rails-buildpack.

febeling avatar febeling commented on May 24, 2024

With @roshiro's confirmation I'm closing this now. Please reopen in case.

from webpack-rails-buildpack.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.