Giter Club home page Giter Club logo

Comments (4)

rvowles avatar rvowles commented on May 23, 2024

thinking the return type would be a map<sdkUrl,List> where the list is only updated features. What do you think @chrusty ?

from featurehub.

chrusty avatar chrusty commented on May 23, 2024

I could imagine an API call that just returns the entire list of features (same payload as you get with the SSE API upon connection / reconnection). Certainly this was my assumption on how the API would work initially!

To me it doesn't make any difference in terms of bandwidth if a user polls for 10 features every 30 seconds or reconnects every 30s to the SSE endpoint to get the same 10 features. The one problem we'd have would be a lack of control over how frequently the user polls the GET endpoint. In our own SDKs we could of course control this, but our own SDKs would be using SSE anyway.

Perhaps some simple rate-limiting middleware if this becomes an issue, but for now probably just keep it simple.

from featurehub.

rvowles avatar rvowles commented on May 23, 2024

@chrusty do you think given it wouldn't be cached anyway, we shouldn't turn it into a POST API then? I'm thinking for feature strategies this would allow the server to evaluate settings as well.

from featurehub.

chrusty avatar chrusty commented on May 23, 2024

@rvowles now that I have the background on this, I think the solution could be to have two endpoints:

  • GET /features could return the entire list of features including their strategies, and leave the interpretation up to the client
  • POST /features would take a bunch of information in the request (client version, OS, random ID etc), and return a pre-interpreted list of features which the client would then blindly apply

from featurehub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.