Comments (4)
thinking the return type would be a map<sdkUrl,List> where the list is only updated features. What do you think @chrusty ?
from featurehub.
I could imagine an API call that just returns the entire list of features (same payload as you get with the SSE API upon connection / reconnection). Certainly this was my assumption on how the API would work initially!
To me it doesn't make any difference in terms of bandwidth if a user polls for 10 features every 30 seconds or reconnects every 30s to the SSE endpoint to get the same 10 features. The one problem we'd have would be a lack of control over how frequently the user polls the GET endpoint. In our own SDKs we could of course control this, but our own SDKs would be using SSE anyway.
Perhaps some simple rate-limiting middleware if this becomes an issue, but for now probably just keep it simple.
from featurehub.
@chrusty do you think given it wouldn't be cached anyway, we shouldn't turn it into a POST API then? I'm thinking for feature strategies this would allow the server to evaluate settings as well.
from featurehub.
@rvowles now that I have the background on this, I think the solution could be to have two endpoints:
- GET /features could return the entire list of features including their strategies, and leave the interpretation up to the client
- POST /features would take a bunch of information in the request (client version, OS, random ID etc), and return a pre-interpreted list of features which the client would then blindly apply
from featurehub.
Related Issues (20)
- Allow server side control of polling intervals per environment/application
- feature request: allow NATS connectivity to be disabled as part of the health check
- How to give "Admin Service Accounts" permissions to create portfolios
- Trying to add a Rollout Strategy to a locked feature fails HOT 1
- Service Not Returning fetures After Minikube Cluster Restart HOT 15
- Make Split Targeting Rules Container Scrollable HOT 3
- FeatureHub Multi-Group Matching Permissions Issue
- Issues when upgrading to 16.3 -> 1.7.0 HOT 3
- A role with the only rights to map/manage group members within application/portfolio HOT 1
- Unexpected error when unlocking/retiring /relocking a feature HOT 2
- OpenFeature standard support HOT 2
- Split Brain on HTTP requests for features flag requests : Dacha restart fixes HOT 5
- Features count per page always resets back to default (5) after each addition of a new feature HOT 2
- Non-deterministic hash seed HOT 4
- Support for deep tracing in k8s/Istio setup HOT 1
- WebHook URL can't be HTTPS HOT 3
- Issues when upgrading to 1.7.0 -> 1.7.1 HOT 3
- Cannot save feature changes HOT 2
- Setting service account permission for one application wipes off that in another account HOT 1
- Error on configure IDP with provider oauth2-keycloak HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from featurehub.