Giter Club home page Giter Club logo

Comments (4)

gmartin-flexe avatar gmartin-flexe commented on July 18, 2024

I think in addition to what @cspalding requested, having consistent request ids across different components would really help to track down how they are interacting (or not).

from featurehub.

rvowles avatar rvowles commented on July 18, 2024

Heya - so a few things I can think of for these points.

  1. Once the jersey tracing is turned on, the entire request and response content (all headers and body both received and sent) is actually put directly into the logs. Only the auth token is obfuscated. I presume the issue is that you don't want the req/response for successful requests only failed ones? This is quite difficult as we don't cache the full body of the incoming request waiting for the outgoing response, as that can be potentially dangerous in terms of denial of service. The other option is OpenTelemetry? Any suggestions that would make it easier are welcome here!

  2. Clearer understanding of the error is probably best on a case by case basis, could you perhaps list some of the errors you are seeing so we can address those? We already have another ticket for addressing the errors in OAuth2 that people are seeing but any input from your team as to the errors would be helpful in making the logging more useful to people!

  3. We use OpenTelemetry and wrap everything in OpenTelemetry support, so "request ids" (i.e. traceids) are already being used across the entire ecosystem. We don't surface OpenTracing trace contexts in the logs however, nor any extra W3C Baggage. You don't normally put these in your logs because they represent spans, and so there is no consistent way to track them by just looking at logs alone. We could add a request id to the baggage and endeavour to log baggage would that be of use?

from featurehub.

rvowles avatar rvowles commented on July 18, 2024

I have added in support for fields from the OTEL baggage into the logs for this to allow cross thread tracking and delivery across the different services. I will be adding it to the UI as well as part of the next update. As I'm not getting more explicit feedback I will leave it at that and close the ticket once those are in.

from featurehub.

rvowles avatar rvowles commented on July 18, 2024

I'll be closing this out on the next release with this piece of doc added: fad1c04

from featurehub.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.