Creating multiple records using service.create(data) with an array yields: no id error about feathers-vuex HOT 9 CLOSED

+1

from feathers-vuex.

Ah, yes. I haven't handled array responses. Thank you for spotting this. I'll probably be able to fix this over the weekend, unless you have the bandwidth to submit a PR. 🙏

from feathers-vuex.

what should i do to filter that progame catch this error

from feathers-vuex.

Is there any news on this? Based on @tommygarces digging, I've been trying to get it to call addOrUpdateList when the response is an array, but it seems I'm missing something else to make it work as intended.

This is what I tried:

return service.create(data).then(function (item) {
    if(item.length){
      dispatch('addOrUpdateList', item)
    }else{
      dispatch('addOrUpdate', item);
    }
    commit('setCurrent', item);
    commit('unsetCreatePending');
    return item;
  }).catch(function (error) {
    commit('setCreateError', error);
    commit('unsetCreatePending');
    return Promise.reject(error);
});

Everything is added to the db and I get no errors, but already in my backend after create hook, the PK id is null.

from feathers-vuex.

The only Problem I see in this is that 'addOrUpdateList' assumes the provided array is the complete list and will remove all items from the store that are not included in the provided array if autoRemove is turned on.
This is what you expect to happen if you dispatch 'find', but unsuitable if you dispatch an bulk request.

There should maybe be two different actions for bulk requests and find.

You could just dispatch 'addOrUpdate' for each item if the response is an array:

return service.create(data).then(function (item) {
  if (Array.isArray(item)) {
    item.forEach(function (item) {
      dispatch('addOrUpdate', item);
    });
  } else {
    dispatch('addOrUpdate', item);
  }
  commit('setCurrent', item);
  commit('unsetCreatePending');
  return item;
}).catch(function (error) {
  commit('setCreateError', error);
  commit('unsetCreatePending');
  return Promise.reject(error);
});

from feathers-vuex.

@Torge thanks for the suggestion, however even when doing it that way, the id = null for the returned items.

from feathers-vuex.

@bobcat1 sorry i looked at your original issue just now, but it seems like this issue in this thread is dealing with the problem of not handeling the response of bulk 'create' as specified here https://docs.feathersjs.com/api/services#createdata-params
data may also be an array.

Your Problem seems to be, not having an unique single id.

from feathers-vuex.

@Torge This issue is not related to #67.

My use case in relation to this specific issue is:
I'm trying to add an array of items, and then I need to use the IDs returned to add more items, based on the IDs returned from the first array. It's just that all IDs are null when returned. So my workaround right now is to make a find call after they have all been added. That way I get all the IDs, and can use them to add the rest of my data.

from feathers-vuex.

This is fixed in the latest pre-release. npm i feathers-vuex@pre, and it will be included in the next minor version.

from feathers-vuex.