Unique index on idField? about feathers-mongodb HOT 7 CLOSED

Yes, we can check for the index, and I do think we should throw if there isn't one. Adding the index should be required, otherwise it's not actually an id field. I'll put together a PR.

from feathers-mongodb.

I was just replying and then @marshallswain beat me to it.

We changed the adapters from doing all the connection and collection setup stuff themselves to just passing the initialized collection. I agree that it makes sense to have the user do it but we should mention it in the docs. Is there maybe also a way to check if there is a unique index on the passed id field and throw a warning?

from feathers-mongodb.

I don't think the adapter should create indexes or unique rules, but it would be nice of us to mention how to do it in the docs.

from feathers-mongodb.

So this becomes really difficult due to the trickery that's demonstrated in the tests. Specifically, initializing a service without a Model and later adding it like app.service('people').Model = db.collection('people'). If this is a common pattern, there's no way to validate the proper index.

My current plan is to validate that Model is a Mongo collection in the constructor, and if so run the index check. If not, there's not much we can do. Not as safe as I'd like, but I guess if users are initializing services without a db, then there's not much to be done.

from feathers-mongodb.

It's really just a workaround for the asynchronous initialization of the plugin (which you correctly pointed out we should solve properly). Could we add a verifyIndices method that can be called manually but also runs in the constructor (if this.Model is set)?

from feathers-mongodb.

Yeah, that's basically the route I've taken. If Model exists, then we check it for the proper index. If not, it's up to the user. I'll update the docs to clarify how this works, and that the index is required for the id field to work properly.

from feathers-mongodb.

I just merged #62 which doesn't have the weird workaround for setting the model. Are we still going to add the index check?

from feathers-mongodb.