Comments (8)
I was out for few days. Just tested Facebook, npm start works fine.
from cli.
The authentication packages need the respective types packages e.g. @types/feathersjs__authentication-oauth2
from cli.
Upon generating authentication with all options selected, the package.json contains
"dependencies": {
"@feathersjs/authentication": "^2.1.7",
"@feathersjs/authentication-jwt": "^2.0.1",
"@feathersjs/authentication-local": "^1.2.1",
"@feathersjs/authentication-oauth2": "^1.1.0",
"@feathersjs/configuration": "^1.0.2",
"@feathersjs/errors": "^3.3.0",
"@feathersjs/express": "^1.2.3",
"@feathersjs/feathers": "^3.1.7",
"@feathersjs/socketio": "^3.2.2",
"ajv": "^6.5.2",
"compression": "^1.7.3",
"cors": "^2.8.4",
"feathers-hooks-common": "^4.14.3",
"feathers-nedb": "^3.1.0",
"helmet": "^3.12.1",
"lodash.merge": "^4.6.1",
"nedb": "^1.8.0",
"passport-auth0": "^1.0.0",
"passport-facebook": "^2.1.1",
"passport-github": "^1.1.0",
"passport-google-oauth20": "^1.0.0",
"serve-favicon": "^2.5.0",
"winston": "^3.0.0"
},
"devDependencies": {
"@types/feathersjs__authentication": "^2.1.1",
"@types/feathersjs__authentication-jwt": "^1.0.3",
"@types/feathersjs__authentication-local": "^1.0.2",
"@types/feathersjs__authentication-oauth2": "^1.0.3",
"@types/nedb": "^1.8.5",
"@types/passport-facebook": "^2.1.8",
"@types/passport-github": "^1.1.3",
"eslint": "^5.1.0",
"mocha": "^5.2.0",
"request": "^2.87.0",
"request-promise": "^4.2.2"
}
So the types packages seem to be included.
from cli.
@eddyystop You say "all options selected"...
I selected all authentication options except auth0 and github, and then I get "@feathersjs/authentication-oauth2": "^1.1.0" in dependencies, but no corresponding devDependencies for types.
I guess there's a missing dependency on types for google and facebook options.
Here's the tail of the log (note there is no @types/feathersjs__authentication-oauth2 anywhere):
...
We are adding the first connection in dir api
? What is the database connection string? nedb://../data
force config\default.json
create src\authentication.ts
force src\app.ts
create test\services\users.test.ts
create src\models\users.model.ts
create src\services\users\users.service.ts
create src\services\users\users.interface.ts
create src\services\users\users.schema.ts
create src\services\users\users.mongo.ts
create src\services\users\users.mongoose.ts
create src\services\users\users.sequelize.ts
create src\services\users\users.validate.ts
create src\services\users\users.hooks.ts
force src\services\index.ts
force src\app.interface.ts
force src\typings.d.ts
npm WARN [email protected] No repository field.
npm WARN [email protected] No license field.
+ @feathersjs/[email protected]
+ @feathersjs/[email protected]
+ @feathersjs/[email protected]
+ [email protected]
+ @feathersjs/[email protected]
+ @feathersjs/[email protected]
+ [email protected]
added 34 packages from 27 contributors and audited 868 packages in 4.764s
found 0 vulnerabilities
npm WARN [email protected] No repository field.
npm WARN [email protected] No license field.
+ @types/[email protected]
+ @types/[email protected]
+ @types/[email protected]
+ @types/[email protected]
added 5 packages from 9 contributors and audited 933 packages in 4.242s
found 0 vulnerabilities
npm WARN [email protected] No repository field.
npm WARN [email protected] No license field.
+ @feathersjs/[email protected]
+ [email protected]
+ [email protected]
+ [email protected]
+ @feathersjs/[email protected]
+ @feathersjs/[email protected]
+ [email protected]
added 9 packages from 7 contributors, updated 7 packages and audited 946 packages in 4.779s
found 0 vulnerabilities
npm WARN [email protected] No repository field.
npm WARN [email protected] No license field.
+ @types/[email protected]
added 1 package from 2 contributors and audited 947 packages in 4.157s
found 0 vulnerabilities
npm WARN [email protected] No repository field.
npm WARN [email protected] No license field.
+ [email protected]
added 7 packages from 9 contributors and audited 957 packages in 4.738s
found 0 vulnerabilities
Here's the resulting package.json:
{
"name": "api",
"description": "Project api",
"version": "0.0.0",
"homepage": "",
"main": "src",
"keywords": [
"feathers"
],
"author": {
"name": "iva2k",
"email": "[email protected]"
},
"contributors": [],
"bugs": {},
"directories": {
"lib": "src",
"test": "test/"
},
"engines": {
"node": "^8.0.0",
"npm": ">= 3.0.0"
},
"scripts": {
"test": "npm run tslint && npm run mocha",
"tslint": "tslint -p tsconfig.json -c tslint.json && tslint -p tsconfig.test.json -c tslint.json",
"start": "ts-node --files src/",
"mocha": "ts-mocha -p tsconfig.test.json 'test/**/*.test.ts' --timeout 10000 --exit",
"compile": "tsc -p tsconfig.json"
},
"dependencies": {
"@feathersjs/authentication": "^2.1.6",
"@feathersjs/authentication-jwt": "^2.0.1",
"@feathersjs/authentication-local": "^1.2.1",
"@feathersjs/authentication-oauth2": "^1.1.0",
"@feathersjs/configuration": "^1.0.2",
"@feathersjs/errors": "^3.3.0",
"@feathersjs/express": "^1.2.3",
"@feathersjs/feathers": "^3.1.7",
"@feathersjs/socketio": "^3.2.2",
"ajv": "^6.5.2",
"compression": "^1.7.2",
"cors": "^2.8.4",
"feathers-hooks-common": "^4.14.3",
"feathers-nedb": "^3.0.1",
"helmet": "^3.12.1",
"lodash.merge": "^4.6.1",
"nedb": "^1.8.0",
"passport-facebook": "^2.1.1",
"passport-google-oauth20": "^1.0.0",
"serve-favicon": "^2.5.0",
"winston": "^3.0.0"
},
"devDependencies": {
"@types/compression": "0.0.36",
"@types/cors": "^2.8.4",
"@types/feathersjs__authentication": "^2.1.1",
"@types/feathersjs__authentication-jwt": "^1.0.3",
"@types/feathersjs__authentication-local": "^1.0.2",
"@types/feathersjs__configuration": "^1.0.1",
"@types/feathersjs__errors": "^3.2.1",
"@types/feathersjs__express": "^1.1.4",
"@types/feathersjs__feathers": "^3.0.4",
"@types/feathersjs__socketio": "^3.0.3",
"@types/helmet": "0.0.38",
"@types/lodash.merge": "^4.6.3",
"@types/mocha": "^5.2.3",
"@types/nedb": "^1.8.5",
"@types/passport-facebook": "^2.1.8",
"@types/request-promise": "^4.1.41",
"@types/serve-favicon": "^2.2.30",
"@types/winston": "^2.3.9",
"mocha": "^5.2.0",
"request": "^2.87.0",
"request-promise": "^4.2.2",
"ts-mocha": "^1.2.0",
"ts-node": "^7.0.0",
"tslint": "^5.10.0",
"typescript": "^2.9.2"
}
}
If I rerun feathers-plus generate authentication
and select Auth0, then, @types/feathersjs__authentication-oauth2 are installed.
from cli.
The issue seems to have been that the auth0 typing was not included for the Google strategy.
Fix published as f+/cli v0.4.16.
Please confirm it fixes the situation. Thanks.
from cli.
Yes, fixed for Google auth.
However, if I select only Facebook, the same typings error remains.
from cli.
Fix published to f+/cli as v0.4.18 running generator v0.2.24.
Please confirm it fixes the situation. Thanks.
from cli.
@iva2k any news?
from cli.
Related Issues (20)
- Cannot start application HOT 1
- Use https on new Feathers (Buzzard) with typescript HOT 6
- Best practices of using generate with prettier HOT 3
- Cannot get simple GraphQL call to complete after following tutorial HOT 8
- Sequelize.ts error HOT 2
- SQL Syntax error with Sequelize, TS and MySQL 8 ?
- regenerating service removes all hooks on service HOT 5
- app#src with multiple path directory fail to start HOT 2
- Feathers Seed MongoDB Race Condition HOT 5
- Feature Request: Add code insertion point HOT 2
- Update Changelog HOT 1
- generate HOT 1
- [Question] "mongo" & "sequelize" files for "mongoose"? HOT 4
- Service fields in mongo/mongoose/sequelize are all string/TEXT, even for numbers HOT 1
- Generated TypeScript version fails to compile - app.configure() type mismatch HOT 8
- Generated TypeScript with custom sources folder fails to "npm start" (again)
- Feature request: Add config option or code insertion point
- Unable to use npx to do a one off command with feather-plus/cli
- getDescription is not a function after generating graphql service HOT 1
- is this cli deprecated? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cli.