Giter Club home page Giter Club logo

Comments (2)

sheerun avatar sheerun commented on August 22, 2024

I think it would be good idea to attach context.Context to ClientContext so implementations can react to closed connection. It would be good to do so even before you figure out how to properly detect it

from ftpserverlib.

fclairamb avatar fclairamb commented on August 22, 2024

I'm closing this because:

  • We are the root of a possible context, the library is not doing anything cancellable, it's only reacting to short commands and piping streams. So I think it makes sense but on the client driver implementation and as such, I'll leave it to the client drivers (in this case the afero ones) to use it.
  • I don't see any place where it could make sense, to be more specific:
    • If a control connection closes, it doesn't mean the transfer connection should be canceled
    • If a transfer connection closes, then that's the end of the file

from ftpserverlib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.