Comments (2)
I think it would be good idea to attach context.Context to ClientContext so implementations can react to closed connection. It would be good to do so even before you figure out how to properly detect it
from ftpserverlib.
I'm closing this because:
- We are the root of a possible context, the library is not doing anything cancellable, it's only reacting to short commands and piping streams. So I think it makes sense but on the client driver implementation and as such, I'll leave it to the client drivers (in this case the afero ones) to use it.
- I don't see any place where it could make sense, to be more specific:
- If a control connection closes, it doesn't mean the transfer connection should be canceled
- If a transfer connection closes, then that's the end of the file
from ftpserverlib.
Related Issues (20)
- EPRT support
- Data race caused by ABOR HOT 1
- do not quit serve loop on temporary accept errors? HOT 1
- Add some badges HOT 1
- Action Required: Fix Renovate Configuration
- Allow users to extend/change handlers HOT 2
- Fix gocover.io HOT 1
- Configurable FTP client authentication method HOT 2
- PASV command crash
- FR: customize error codes HOT 6
- LIST command doesn't work for file HOT 1
- Dependency Dashboard
- Add support for wildcards in LIST HOT 2
- Restore IPv6 support HOT 1
- MLSD Response: 550 Could not list: Not supported HOT 1
- MLST gives incorrect response HOT 6
- Unable to catch abort transfer from client HOT 1
- protocol not available, Unable to open transfer HOT 3
- Could not list the contents of the bucket , throws 550 error (afero-s3) HOT 1
- APPE should create a file if it does not yet exist
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ftpserverlib.