Error trying to use in a Cloudflare Worker about faunadb-js HOT 13 CLOSED

just a small note. Cloudflare doesn't implement AbortController which we need to terminate requests as well as streams. so it better to pass customized fetch. for example:

            const client = new faunadb.Client({
                'secret': 'your secret',
                fetch: (url, params) => {
                    const signal = params.signal
                    delete params.signal
                    const abortPromise = new Promise(resolve => {
                        if(signal) {
                            signal.onabort = resolve
                        }
                    })
                    return Promise.race([abortPromise, fetch(url, params)])
                }
            })

from faunadb-js.

Is there any reason cross-fetch doesn't just use the global fetch when it exists?

from faunadb-js.

just a small note. Cloudflare doesn't implement AbortController which we need to terminate requests as well as streams. so it better to pass customized fetch. for example:

            const client = new faunadb.Client({
                'secret': 'your secret',
                fetch: (url, params) => {
                    const signal = params.signal
                    delete params.signal
                    const abortPromise = new Promise(resolve => {
                        if(signal) {
                            signal.onabort = resolve
                        }
                    })
                    return Promise.race([abortPromise, fetch(url, params)])
                }
            })

this one actually works :O) previous solution fetch.bind(globalThis) Isn't work with fauna v4.x.x

from faunadb-js.

Hi @lolcoolkat thanks for the fix.

1. We used cross-fetch because some environments was having compatibility issues. So we need to find another solution instead of just remove it.

2. I have to check what it is doing.

from faunadb-js.

@lolcoolkat NodeJS does not support fetch() natively so we need to use some polyfill like cross-fetch to make driver works on both environments (browser and nodejs). Unfortunately, we didn't find out a polyfill that was not using XMLHttpRequest however we are brainstorming to see what we can do about this issue so please, let us know if you have any ideas on your mind.

from faunadb-js.

@BrunoQuaresma We use Axios in the browser and on our node backend. Have you considered using that?

from faunadb-js.

@eigilsagafos I think axios uses XMLHttpRequests right?

from faunadb-js.

Yeah... you are right. Was just looking at that.

from faunadb-js.

I know some packages build for different environments and allow you to require like require("fauna/browser") and require("fauna/node"). Maybe you could even provide a barebones version where you could provide your own http adapter?

from faunadb-js.

Yeah, we are thinking on this solution as well but it adds some extra effort to define a common API interface that should work for these environments. Sounds strange to me a serverless environment does not support core NodeJS stuff. 🤔

from faunadb-js.

Yeah Cloudflare Workers run ontop of V8 and without all the NodeJS overhead.. that's why they are super quick and performant!

Cool, that makes sense.

Doesn't have to be exactly like that, but hopefully you get the idea :D And that config would allow you to specify whether to use cross-fetch or not?

I think it is a nice suggestion. We will evaluate that. Thanks for the contribution @lolcoolkat

from faunadb-js.

@lolcoolkat yes it is! We just need to add some tests and an extra environment in our pipeline to check things on V8 environments. Thanks for the suggestion.

from faunadb-js.

Fixes on https://www.npmjs.com/package/faunadb/v/2.11.2-beta. We are releasing this soon on the main version.

from faunadb-js.