Giter Club home page Giter Club logo

Comments (5)

bhcleek avatar bhcleek commented on June 3, 2024

Yes, I agree that it looks like we could shift to checking the exit code to be sure that it's 2. I also think it's worth submitting a PR to vim-vimlint to use grep -E instead of egrep in an attempt to avoid a more complete future breakage.

from vim-go.

matthewhughes934 avatar matthewhughes934 commented on June 3, 2024

I also think it's worth submitting a PR to vim-vimlint to use grep -E instead of egrep in an attempt to avoid a more complete future breakage.

👍 syngan/vim-vimlint#124 though I'm not too optimistic about it being reviewed/merged any time soon 😅

from vim-go.

bhcleek avatar bhcleek commented on June 3, 2024

I'm having a hard time duplicating this.

vim-go@bc579251da29:~$ make lint
==> Running linting tools
Running vint ... PASSED
Running vim-vimlint ... PASSED
Running vimhelplint ... PASSED
vim-go@bc579251da29:~$ grep --version
grep (GNU grep) 3.8
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Mike Haertel and others; see
<https://git.sv.gnu.org/cgit/grep.git/tree/AUTHORS>.
vim-go@bc579251da29:~$ egrep --version
grep (GNU grep) 3.8
Copyright (C) 2022 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html>.
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Mike Haertel and others; see
<https://git.sv.gnu.org/cgit/grep.git/tree/AUTHORS>.
vim-go@bc579251da29:~$

from vim-go.

matthewhughes934 avatar matthewhughes934 commented on June 3, 2024

I'm having a hard time duplicating this.

Is your version of grep packaged by Debian/are you running on a Debian based distro? It looks like they have a patch to suppress that warning

Equivalently: does egrep --version emit a warning for you? For reference, I'm running on Arch:

$ docker run archlinux:latest egrep --version >/dev/null
egrep: warning: egrep is obsolescent; using grep -E
$ docker run debian:latest egrep --version >/dev/null

from vim-go.

bhcleek avatar bhcleek commented on June 3, 2024

Ah, yup, that would do it. Thank you 🙇 .

from vim-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.