Comments (5)
@ryanve I completely agree with you here, and not just for jQuery compatibility, the trigger
arg stuff is a bit of a mess. Also, given the fact that we do a lot of manual handler triggering now we can do some Event
object emulation stuff, like jQuery does.
Consider this jQuery, a pattern used a bit in Bootstrap:
var e = $.Event('show')
el.trigger(e)
if (!e.isDefaultPrevented()) {
// do something
}
Being able to create and retain the event object has a heap of benefits.
Unfortunately the horse has bolted on that and it's a bit difficult to change the API. Perhaps we'll try and solicit some feedback on this to see if anyone is actually using the trigger arguments in Bean.
from bean.
@ded @connor @st-luke @iamdustan (or anyone else?) got an opinion on this?
from bean.
I'm not using trigger args in bean but normalization is a good thing if it can be done without totally screwing people.
from bean.
I'm also not using trigger arguments in any projects using Bean (although may discover some during the conversion, Rod, like we talked about over email). I'm for the first element in the array being reserved for an eventData
object.
from bean.
I agree with the argument presented here that the first argument should be reserved for the eventData object and the second being optional arguments. It’s clean and provides an expected and consistent way to determine how the event was triggered and how to access your custom arguments.
I haven’t used the trigger arguments because of how it’s applied currently (I tried. I may still have used it, but it definitely caused some confusion at the time)
from bean.
Related Issues (20)
- The event argument is not passed for listners attached to a JS object HOT 7
- focusin/focusout does not work in IE8
- API Documentation bug
- Ender methods conflicts with Bonzo HOT 1
- textinput event doesn't work
- Support matchesSelector and the like HOT 1
- IE8 can't fire native events on window
- Missing semi-colon at end of minified version. HOT 5
- Cannot `one()` recursively HOT 1
- copy, cut, paste events
- Events not firing in Chrome/Chromium since v42 HOT 3
- Custom events doesn't bubble HOT 1
- Allow bean.off to use selectors as bean.on does HOT 3
- KeyboardEvent.keyIdentifier deprecated
- No valid bower.json was found in any branch or tag of https://github.com/fat/bean.git HOT 2
- Typo in README
- Is it possible to listen to propertychange events from INPUT elements?
- Expresso Emporium
- hi
- bean is not compatible with "ender compile" HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bean.