Object support and custom events about bean HOT 6 CLOSED

Currently an event is not passed to elements -- because it's less of an event than a callback. However, with the next major release of bean, you'll be passed an even obj.

With the firing of custom events, you don't need to put your args in an array.

just do:

 bean.fire(obj, 'doSomething', 'val1', 'val2');

from bean.

Hi just picking this back up again. When I try your above suggestion I get the following error:

second argument to Function.prototype.apply must be an array
bean.js
Line 193

Any ideas? I'm still looking into this myself, but even when I do pass any array, I only the first element of the array is passed as an argument to the event handler function.

Many thanks in advance

from bean.

Hi, don't worry about this. Issue still stands, but we've developed our own event framework. Many thanks.

from bean.

Hi guys, I was experiencing the same problem as above (ie, second argument to Function.prototype.apply must be an array). It seems you do need to pass your arguments to custom events in an array (which probably better anyway) but I noticed only the first argument was making it back to the handler.

To fix the problem I've changed the definition of customHandler as follows in our local copy from:

  customHandler = function (element, fn, type, condition, args) {
    return function (event) {
      if (condition ? condition.call(this, event) : W3C_MODEL ? true : event && event.propertyName == '_on' + type || !event) {
        fn.apply(element, [event].concat(args));
      }
    };
  },

to:

  customHandler = function (element, fn, type, condition, args) {
    return function (event) {
      if (condition ? condition.call(this, event) : W3C_MODEL ? true : event && event.propertyName == '_on' + type || !event) {
        fn.apply(element, Array.prototype.slice.call(arguments).concat(args));
      }
    };
  },

I'm not sure if this is the best solution, and neither am I sure whether or not it affects anything else - hence no pull request - but hopefully this is useful :)

from bean.

I went the other way and just pass an array of a single element that acts as an event object.

bean.fire(myObject, 'myEvent', [ { keyOne: 'valueOne', keyTwo: 'valueTwo' } ]);

And in the event handler:

function handler (ev) {
  console.log(ev.keyOne); // valueOne
}

That said, I think there is a bug with my approach. I have opened a separate ticket about it: #18.

from bean.

this is working now with this commit: 8b8851a

i'll be republishing to npm this evening. thanks for all your help!

from bean.