Giter Club home page Giter Club logo

Comments (12)

rais38 avatar rais38 commented on March 28, 2024

If I include the version in the Deliverfile if it works ... This is correct?

from fastlane.

KrauseFx avatar KrauseFx commented on March 28, 2024

Well, it should fetch the version number from the ipa file. Looks like deliver has issues detecting the version number.

from fastlane.

KrauseFx avatar KrauseFx commented on March 28, 2024

Might be caused by too many plist files:

fastlane-old/deliver#73

I need more information about the extracted ipa file to solve this problem.

from fastlane.

rais38 avatar rais38 commented on March 28, 2024

I can see in generated ipa file there are some plist files:

  • For own consumption of the app in the root of .app folder
  • Inside each storyboards of the app
  • In the localization folders (en.lproj, es.lproj...)
  • And only one Info.plist in the root folder with the relevant information CFBundleShortVersionString, CFBundleVersion...

This information can help you?

from fastlane.

patoroco avatar patoroco commented on March 28, 2024

Same here with last fastlane version

from fastlane.

KrauseFx avatar KrauseFx commented on March 28, 2024

Sorry about that, you can pass the version number manually and provide your own automatic detection of the version number using PlistBuddy 😞

from fastlane.

patoroco avatar patoroco commented on March 28, 2024

It's possible to send version as parameter? Or we should update DeliverFile programmatically?

from fastlane.

KrauseFx avatar KrauseFx commented on March 28, 2024

Yes, of course: https://github.com/KrauseFx/deliver/blob/master/Deliverfile.md#version

Just add

version "1.0"

or something like

version File.read("file.txt")

or your own script

from fastlane.

patoroco avatar patoroco commented on March 28, 2024

Oh, nice approach! Maybe I'll do one action for that :)

Finally I used these two lines:

FastFile:

before_all do |lane|
system("/usr/libexec/plistbuddy -c Print:CFBundleShortVersionString '../myProject-Info.plist' > ./app_version.txt")
end

DeliverFile (as you said @KrauseFx):

version File.read('./app_version.txt')

In my case, I added fastlane/app_version.txt to my .gitignore, opinions?

from fastlane.

KrauseFx avatar KrauseFx commented on March 28, 2024

Change it to just

version `"/usr/libexec/plistbuddy -c Print:CFBundleShortVersionString '../myProject-Info.plist'`

and remove the before_all

🚀

from fastlane.

patoroco avatar patoroco commented on March 28, 2024

👏

from fastlane.

KrauseFx avatar KrauseFx commented on March 28, 2024

This is also improved with the latest version 👍

from fastlane.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.