Giter Club home page Giter Club logo

Comments (9)

smartiniOnGitHub avatar smartiniOnGitHub commented on May 18, 2024 1

@mcollina ok. I just created the PR33.
Due to lack of time now it's without tests but I'll add them in a few days.
As always comments and suggestions are welcome :-) ... thanks for now. Bye

from point-of-view.

zhenruyan avatar zhenruyan commented on May 18, 2024 1

@smartiniOnGitHub Thank you very much.

from point-of-view.

mcollina avatar mcollina commented on May 18, 2024

I think fastify is doing the correct thing. If your application throw it is better to crash, otherwise you are going to leak memory.

What we can do is to catch and send that to the error handler... the user will see a 500. Would this be bettere?

from point-of-view.

zhenruyan avatar zhenruyan commented on May 18, 2024

So how do I catch this exception, it seems to be in the form of Plug-ins, in the plug-in callback? or where?

from point-of-view.

mcollina avatar mcollina commented on May 18, 2024

very likely we would have to add it in this library.

Would you mind sending a PR?

from point-of-view.

smartiniOnGitHub avatar smartiniOnGitHub commented on May 18, 2024

Hi all, I just started an implementation for this (I have the same problem even when an EJS include file is missing and I need to have it fixed), I hope to push something for a PR soon ...

from point-of-view.

smartiniOnGitHub avatar smartiniOnGitHub commented on May 18, 2024

To speedup development cycles in some projects I use nodemon ... if I'd add it in dev dependencies here and add a custom npm command to have an hot-reloadable dev server ?
@mcollina What do you think ?

from point-of-view.

mcollina avatar mcollina commented on May 18, 2024

The best way to develop this is via unit tests, not with a “hot-reloadable dev server”, I’m kind of -1. There is no need to add this to package.json either as you can use it from a global installation.

from point-of-view.

smartiniOnGitHub avatar smartiniOnGitHub commented on May 18, 2024

@mcollina This could be closed now (just merged) ... thanks a lot.

from point-of-view.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.