Comments (9)
Iām +1 on setting the mime type every time in this plugin if it is not set when calling view. PR?
from point-of-view.
ok, give me only some days to understand where (and how :-) ) to do changes ...
from point-of-view.
Sorry, could you merge (if good enough) my other PR so here I can start from an updated master ?
Thanks a lot and sorry for this request :-) .
from point-of-view.
We should be good now!
from point-of-view.
@mcollina you beat me over time on this PR :-) .
Sorry but for the changes in this PR my intention was to put that encoding as default in the plugin (when serving pages), so I think changing this line:
that.header('Content-Type', 'text/html').send(html)
and then cleanup any reference to '; charset=utf-8' ...
But my idea is right (for how this plugin works) ?
Or is it a behavior wanted here (I think it will be safer and should not do damage nor problems) ?
If accepted, I still need to do changes here, so we should reopen this (if possible) or I'll crete a new one.
Tell me. Thanks.
from point-of-view.
No big deal, reopening! Feel free to send a new PR!
from point-of-view.
#31
@mcollina All should be done ... anyway tell me if there is some change or improvement still to do.
Thanks, Sandro
from point-of-view.
Previous PR closed (was outdated), the new one is #35
from point-of-view.
PR has been merged.
from point-of-view.
Related Issues (20)
- Dependency version mismatch HOT 2
- version issue
- view not rendering ejs and keep getiing FST_ERR_REP_ALREADY_SENT error HOT 2
- TS definitions missing third parameter for the view function HOT 1
- how to use same identifier for different directory paths in ejs with different static assest folder HOT 1
- Typedefs don't support "view" method in FastifyInstance
- Errors in eta template usinc async mode are not catched HOT 12
- Deoptimized access to `reply.locals` HOT 4
- Type of templates property in PointOfViewOptions show allow arrays HOT 1
- Allow custom `Content-Type` header for Nunjucks HOT 1
- How to render view dynamically by http status on ExceptionFilter HOT 1
- Nunjucks templates do not dynamically reload in development HOT 4
- could you add support of svelte? HOT 1
- support for async minify methods HOT 3
- eta v3 integration doesn't work HOT 1
- nunjucks custom filter is not working HOT 1
- I am getting the following error after installing and configuring the lib: reply.view is not a function HOT 2
- Latest version of Eta no longer works HOT 6
- Support for view raw text
- `fastify.view` is rendered without `reply.locals` HOT 18
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from point-of-view.