Giter Club home page Giter Club logo

Comments (9)

mcollina avatar mcollina commented on May 18, 2024

Iā€™m +1 on setting the mime type every time in this plugin if it is not set when calling view. PR?

from point-of-view.

smartiniOnGitHub avatar smartiniOnGitHub commented on May 18, 2024

ok, give me only some days to understand where (and how :-) ) to do changes ...

from point-of-view.

smartiniOnGitHub avatar smartiniOnGitHub commented on May 18, 2024

Sorry, could you merge (if good enough) my other PR so here I can start from an updated master ?
Thanks a lot and sorry for this request :-) .

from point-of-view.

mcollina avatar mcollina commented on May 18, 2024

We should be good now!

from point-of-view.

smartiniOnGitHub avatar smartiniOnGitHub commented on May 18, 2024

@mcollina you beat me over time on this PR :-) .
Sorry but for the changes in this PR my intention was to put that encoding as default in the plugin (when serving pages), so I think changing this line:
that.header('Content-Type', 'text/html').send(html)
and then cleanup any reference to '; charset=utf-8' ...
But my idea is right (for how this plugin works) ?
Or is it a behavior wanted here (I think it will be safer and should not do damage nor problems) ?
If accepted, I still need to do changes here, so we should reopen this (if possible) or I'll crete a new one.
Tell me. Thanks.

from point-of-view.

mcollina avatar mcollina commented on May 18, 2024

No big deal, reopening! Feel free to send a new PR!

from point-of-view.

smartiniOnGitHub avatar smartiniOnGitHub commented on May 18, 2024

#31
@mcollina All should be done ... anyway tell me if there is some change or improvement still to do.
Thanks, Sandro

from point-of-view.

smartiniOnGitHub avatar smartiniOnGitHub commented on May 18, 2024

Previous PR closed (was outdated), the new one is #35

from point-of-view.

smartiniOnGitHub avatar smartiniOnGitHub commented on May 18, 2024

PR has been merged.

from point-of-view.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.