Comments (7)
Thank you for accepting a PR on this, it's a great help.
A member of our platform team has raised a case with GCP asking about the reasoning behind moving authentication onto the x-forwarded-authorization
header, and as you point out, breaking the specification. I'll try to update here with the outcome of that.
from fastify-basic-auth.
Thanks, I'll try and get something up in a PR shortly.
I'm not clear why the gateway would violate the spec and necessitate this module to do the same
It's a fair question, I guess they see this as a gateway to a system rather than a proxy to another API, though I'm speculating.
from fastify-basic-auth.
Would you like to send a Pull Request to address this issue? Remember to add unit tests.
from fastify-basic-auth.
I'm not clear why the gateway would violate the spec and necessitate this module to do the same -- https://datatracker.ietf.org/doc/html/rfc7235#section-4.2
A proxy forwarding a request MUST NOT modify any Authorization fields
in that request. See Section 3.2 of [RFC7234] for details of and
requirements pertaining to handling of the Authorization field by
HTTP caches.
from fastify-basic-auth.
PRs are welcome!
from fastify-basic-auth.
Tried set header but still not working. still by default still get the header with the key is: Authorization
from fastify-basic-auth.
The update here doesn't do anything to modify the Authorization header, it informs the fastify-basic-auth plugin to perform checks against a second named header rather than whatever is on the Authorization header.
from fastify-basic-auth.
Related Issues (7)
- UnauthorizedError: Missing or bad formatted authorization header HOT 5
- Add TypeScript definitions HOT 3
- What is disableHook option for? HOT 1
- Add example of how to add credentials to request to README HOT 1
- ChainAlert: npm package release (2.3.0) has no matching tag in this repo
- Allow custom decorate name HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fastify-basic-auth.