Set custom auth header about fastify-basic-auth HOT 7 CLOSED

Thank you for accepting a PR on this, it's a great help.

A member of our platform team has raised a case with GCP asking about the reasoning behind moving authentication onto the x-forwarded-authorization header, and as you point out, breaking the specification. I'll try to update here with the outcome of that.

from fastify-basic-auth.

Thanks, I'll try and get something up in a PR shortly.

I'm not clear why the gateway would violate the spec and necessitate this module to do the same

It's a fair question, I guess they see this as a gateway to a system rather than a proxy to another API, though I'm speculating.

https://cloud.google.com/endpoints/docs/openapi/service-account-authentication#receiving_authenticated_results_in_your_api

from fastify-basic-auth.

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

from fastify-basic-auth.

I'm not clear why the gateway would violate the spec and necessitate this module to do the same -- https://datatracker.ietf.org/doc/html/rfc7235#section-4.2

A proxy forwarding a request MUST NOT modify any Authorization fields
in that request. See Section 3.2 of [RFC7234] for details of and
requirements pertaining to handling of the Authorization field by
HTTP caches.

from fastify-basic-auth.

PRs are welcome!

from fastify-basic-auth.

Tried set header but still not working. still by default still get the header with the key is: Authorization

from fastify-basic-auth.

The update here doesn't do anything to modify the Authorization header, it informs the fastify-basic-auth plugin to perform checks against a second named header rather than whatever is on the Authorization header.

from fastify-basic-auth.