Use with fluent-json-schema now requires to call valueOf in ObjectSchema when using Typescript about env-schema HOT 7 OPEN

I would also revert the problematic PR and maybe add fluent-json-schema as dependency or as peerDependency

from env-schema.

cc @klaseca

I think I would revert all those changes. It cannot support all the third-party library. Especially, it cannot support fluent-json-schema.

from env-schema.

Under the hood, valueOf is called when passing a schema from fluent-json-schema. How about we remove this code and explicitly call valueOf when passing the schema? It seems to me that if env-schema should work not only with fluent-json-schema, then there should be no code specifically for this library

from env-schema.

How about we remove this code and explicitly call valueOf when passing the schema?

No, it should support out-of-the-box. Since, fastify itself do the same.
cc @fastify/core WDYT?

Anyway, it would be a breaking change in either end. If no other fixes come up, the only choice is revert on current release.

from env-schema.

Perhaps the best solution in this situation would be to return the object type for the schema. At the same time, leave the re-import of the JSONSchemaType type from the ajv package. In this case, we will return the previous fully working state and leave the option to declare a type-checked schema

from env-schema.

Fastify can support fluent-json-schema without the need of it being a dependency. Take a look how it's done there.

from env-schema.

FWIW: Something similar is going on with types here when using with typebox

from env-schema.