Giter Club home page Giter Club logo

Comments (3)

savsgio avatar savsgio commented on May 24, 2024 1

Hi @alex-rufo and @Dot-H,

I've been release v1.1.2 that's fix the issue.

Thanks!

from router.

savsgio avatar savsgio commented on May 24, 2024

Hi @alex-rufo ,

Well seen!
I fount the error, so i will fix it soon.

Thanks.

from router.

Dot-H avatar Dot-H commented on May 24, 2024

Hey 👋

I think I spotted a related issue. Using a custom OPTIONS handler with catch-all parameters always leads to 308. This happens only since 1.1.0.

I adapted @alex-rufo 's code to be able to reproduce:

package main

import (
	"log"

	"github.com/fasthttp/router"
	"github.com/valyala/fasthttp"
)

func Catchall(ctx *fasthttp.RequestCtx) {
	ctx.WriteString("Catchall!")
}

func Specific(ctx *fasthttp.RequestCtx) {
	ctx.WriteString("Specific!")
}

func main() {
	r := router.New()
	r.HandleOPTIONS = false
	r.OPTIONS("/{path:*}", Catchall)
	r.POST("/specific/", Specific)

	log.Fatal(fasthttp.ListenAndServe(":8080", r.Handler))
}

Before, calling

curl -v -X OPTIONS 'localhost:8080/specific/'

would lead to 200 and Catchall! being printed.

For 1.1.1 and 1.1.0, the same command leads to 308.

from router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.