lesson1-pets.ipynb now gives 'expecting number but found string' about course-v3 HOT 15 CLOSED

does it change if you do:
perl -pi -e 's|execution_count": null|execution_count": 1|g' nbs/dl1/*ipynb
it will change 'null' to a number.

Also note, that it's the same setup we have for all fastai notebooks, it just wasn't happening for the course notebooks until a few days ago. So the issue is with the jupyter.

from course-v3.

Actually, installing client 5.2.3 did not fix the issue for me (after checking out a fresh course-v3 repo, the errors returned.)

But what did fix the issue for me was to install a new version of notebook, either using the pip that is part of anaconda: pip install notebook==5.7.0

Or by running conda install notebook=5.7.0 (I tried both ways, uninstalling notebook in between).

Either way solves the problem. Thus upgrading the dependency to notebook>=5.7.0 should have the desired effect.

×
About Jupyter Notebook
Server Information:
You are using Jupyter notebook.

The version of the notebook server is: 5.7.0
The server is running on this version of Python:
Python 3.6.5 |Anaconda custom (64-bit)| (default, Aug 3 2018, 14:28:11)
[GCC 4.8.2 20140120 (Red Hat 4.8.2-15)]

Current Kernel Information:
Python 3.6.5 |Anaconda custom (64-bit)| (default, Aug 3 2018, 14:28:11)
Type 'copyright', 'credits' or 'license' for more information
IPython 6.3.1 -- An enhanced Interactive Python. Type '?' for help.

....With that, all the notebooks work fine as the currently are in this repo. Problem now resolved for me. Thanks very much @stas00 !

from course-v3.

Awesome - thank you for helping out on that, @drscotthawley . I got totally lost in all the different jupyter packages.
notebook>=5.7.0 is the new dependency - so everybody will get it right.

from course-v3.

Ok...that's the thing: My attempts at updating jupyter have simply continued to install this same version. As I say, this version arrives simply as a part of following the installation instructions for fastai.

So, these installation instructions, or the bindings between the fastai conda package and jupyter, may require revision in order to avoid similar problems for (myself and) other users in the future.
Even conda install -c conda-forge jupyter_server still installs 5.2.2, and trying to specify jupyter_server=5.7.0 produces a PackagesNotFoundError.

So...how did you get 5.7.0?

from course-v3.

Stas00: Your suggestion worked like a charm. No errors so far. Thanks
perl -pi -e 's|execution_count": null|execution_count": 1|g' nbs/dl1/*ipynb
it will change 'null' to a number.

from course-v3.

perhaps you have a merge conflict? i.e. your nb's json is messed up?
https://docs-dev.fast.ai/troubleshoot#installation-updates

try to remove the file completely and do git pull again.

from course-v3.

There is no merge. I grab "a completely fresh clone of the entire course-v3 repo." Deleting the prior directory before doing so.
Or instead of git-cloning the entire repo, one can simply get the file itself via "curl -LO https://github.com/fastai/course-v3/raw/master/nbs/dl1/lesson1-pets.ipynb" It makes no difference. The same error persists (in the newer versions of the file, not the older versions).
Updating fastai (with conda) has no effect. Uninstalling both fastai and jupyter and re-installing (via conda) also have no effect.

Are you using a more recent version of Jupyter than is in the conda distribution? Perhaps we need to build Jupyter from source?
I notice that 8 days ago there was a similar error and talk of a fix: jupyter/notebook#4065
but in the conda distro the file seems to be 28 days old: https://anaconda.org/anaconda/jupyter

Can you confirm that this file still loads for you without this error?

from course-v3.

Thank you for clarifying that it's not a merge issue.

My jupyter's version is:

Server Information:
You are using Jupyter notebook.

The version of the notebook server is: 5.7.0
The server is running on this version of Python:
Python 3.6.6 |Anaconda custom (64-bit)| (default, Oct  9 2018, 12:34:16) 
[GCC 7.3.0]

Current Kernel Information:
Python 3.6.6 |Anaconda custom (64-bit)| (default, Oct  9 2018, 12:34:16) 
Type 'copyright', 'credits' or 'license' for more information
IPython 6.5.0 -- An enhanced Interactive Python. Type '?' for help.

which is yours?

from course-v3.

@stas00 That solves the problem on my end. The notebook now loads properly with no error message, and all the other notebooks (which were giving the same error) are now able to load too. Thank you.

from course-v3.

Excellent,
So your jupyter is not respecting the spec then, it should be able to handle:

"execution_count": null,

you still didn't say what your jupyter's version is - jupyter's menu -> Help -> About

from course-v3.

Jupyter version is 4.4.0, (re)installed today from conda. I was trying to find out how to print all that other info...thanks. Here it is:

×
About Jupyter Notebook
Server Information:
You are using Jupyter notebook.

The version of the notebook server is: 5.2.2
The server is running on this version of Python:
Python 3.6.5 |Anaconda custom (64-bit)| (default, Aug 3 2018, 14:28:11)
[GCC 4.8.2 20140120 (Red Hat 4.8.2-15)]

Current Kernel Information:
Python 3.6.5 |Anaconda custom (64-bit)| (default, Aug 3 2018, 14:28:11)
Type 'copyright', 'credits' or 'license' for more information
IPython 6.3.1 -- An enhanced Interactive Python. Type '?' for help.

This is on Ubuntu 16.04.
This jupyter is the one that auto-installs when one installs fastai with conda.

from course-v3.

yes, the link you posted in your original post said that it was a bug in jupyter and it has been fixed. so yes, please update to 5.7.0, and it will get resolved.

I will close this ticket, and if you still have an issue please reopen it.

from course-v3.

conda has 5.2.3 https://anaconda.org/anaconda/jupyter_client

pypi has 5.2.3

from course-v3.

we have just updated fastai's dependencies to jupyter-client>=5.2.3

from course-v3.

So...how did you get 5.7.0?

sorry, I didn't realize it, I got it from the unreleased git, as I was testing some other bug fix.

But 5.2.3 will do the trick.

from course-v3.