PNG watermark issue? about terminalizer HOT 9 CLOSED

Can you please send me the recording file and the watermark ?
Have you tried to edit the same recording file and remove the watermark and then start rendering ?

It seems not related to the watermark itself, Terminalizer renders the frames into png files then merges them into a single gif image.

from terminalizer.

Yes I tried to delete the config file completely (to force all defaults) and it still won't render. So yes, it's not about the watermark.

https://gist.github.com/alicam/4a522bdbea889d1061ead09510cc0bbf

That's my demo.yml file, there.

It fails on the render of the 44th (or 45th) frame, if that helps.

from terminalizer.

I'll delete that gist once you've had a look, by the way. I'm not happy to leave it there for long!

from terminalizer.

@alicam I am not able to reproduce the issue on my machine. It is most likely a bug about how the streams are handled in pngjs package, I found an issue about that in their repo.

So what I am going to do is to release a new release that doesn't pipe a stream into pngjs.

Is this issue happen every time you try to render ? I hope yes so you can help me trying the new approach.

from terminalizer.

@alicam A fix is pushed :)

Please try to render using your current version and make sure there is an error then update the version and try again to check that the error is not longer appears.

To update:

npm install -g terminalizer

from terminalizer.

No luck, I'm sorry.

I did do as you said: I ran it again, it failed, the I upgraded and it still failed:

Merging frame 44/172 26% [========----------------------] 153.2sevents.js:183
      throw er; // Unhandled 'error' event
      ^

Error: Stream not writable
    at module.exports.ChunkStream.write (/usr/local/lib/node_modules/terminalizer/node_modules/pngjs/lib/chunkstream.js:46:24)
    at exports.PNG.PNG.write (/usr/local/lib/node_modules/terminalizer/node_modules/pngjs/lib/png.js:93:16)
    at ReadStream.ondata (_stream_readable.js:639:20)
    at emitOne (events.js:116:13)
    at ReadStream.emit (events.js:211:7)
    at addChunk (_stream_readable.js:263:12)
    at readableAddChunk (_stream_readable.js:250:11)
    at ReadStream.Readable.push (_stream_readable.js:208:10)
    at fs.read (fs.js:2051:12)
    at FSReqWrap.wrapper [as oncomplete] (fs.js:658:17)

from terminalizer.

By the way, I have rendered successfully on this machine. It's just this one that is failing. I don't want you to think it's never worked for me :)

from terminalizer.

@alicam Ops I forgot to do npm publish :) Please upgrade and try again :)

from terminalizer.

@alicam Please confirm and close the issue if fixed :)

from terminalizer.