Comments (16)
fangfufu
commented on June 14, 2024
1
Ok, I added a new feature to cache the directory structure, hence the version number bump. Once you finish making all the changes, let's bump the version number again.
Once again, I am sorry for rebasing the repository - I definitely won't do it again!
from httpdirfs.
jcharaoui
commented on June 14, 2024
1
@fangfufu If I may make a suggestion: there's no need to create a new release every time you push a bugfix or feature. Instead, just push whatever you need to master. Once you're satisfied, let it settle for a while. Give users the chance to report bugs. Then when the code is stabilised and the last few commits are bug fixes, its a good time for a release. To be honest I don't feel it's very prudent to push code that has been just written and barely tested into Debian. This carries the risk of causing problems for users, which we want to avoid at all costs.
from httpdirfs.
fangfufu
commented on June 14, 2024
1
@jcharaoui , Hey Debian Buster has been released. Shall we start working on this again?
from httpdirfs.
jcharaoui
commented on June 14, 2024
I'm going to look to push an update to Debian.
For now I just want to point out that you seem to have rebased the repository, which means that I now need to start with a fresh httpdirfs repository on my end. Please, in the future, avoid at all costs rebasing commits that have been pushed to the master branch, and instead use development/feature branches.
from httpdirfs.
fangfufu
commented on June 14, 2024
Yes, sorry, I did run the rebase command - I wasn't entirely sure what I was doing. I will bear that in mind in the future.
from httpdirfs.
fangfufu
commented on June 14, 2024
@jcharaoui , I agree. I don't have much software development experience, so I am still learning the convention and etiquette.
So I guess it might be a good idea to come back in two weeks and think about pushing the code to Debian. I think it is a good idea to let the code settle down a bit. I am currently testing the code by running it on my server. I am trying to cache a fairly large http directory.
However, I have to say that the code in the repository is way better than the version in Debian. In particular, release 1.0.3 fixes failure when encountering directory with long listing, and release [1.1.0] fixes a memory leak during LinkTable creation - I couldn't cherry pick bug fix part of the code, so I decided to release the new feature alongside with the bug fix.
from httpdirfs.
fangfufu
commented on June 14, 2024
@jcharaoui , hey is there anything I could do to help? :-)
from httpdirfs.
jcharaoui
commented on June 14, 2024
@fangfufu Could you update the changelog and tag 1.1.7 ?
from httpdirfs.
fangfufu
commented on June 14, 2024
I updated the change log and Makefile. I haven't created a tag for 1.1.7 yet, because you have made some changes, feel free to tag 1.1.7 once you finish making all the changes. :-)
from httpdirfs.
jcharaoui
commented on June 14, 2024
I tagged 1.1.7 but unfortunately it doesn't build with Debian unstable:
cc -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2 -fdebug-prefix-map=/build/httpdirfs-fuse-1.1.7=. -fstack-protector-strong -Wformat -Werror=format-security -g -O2 -Wall -Wextra -Wshadow -D_FILE_OFFS
ET_BITS=64 -DVERSION=\"1.1.7\" `pkg-config --cflags-only-I gumbo libcurl fuse` -Wl,-z,relro -Wl,-z,now -pthread -lgumbo -lcurl -lfuse -lcrypto `pkg-config --libs-only-L gumbo libcurl fuse` -o
httpdirfs main.o network.o fuse_local.o link.o cache.o util.o
/usr/bin/ld: network.o: in function `curl_multi_perform_once':
./src/network.c:155: undefined reference to `curl_multi_perform'
/usr/bin/ld: ./src/network.c:157: undefined reference to `curl_multi_strerror'
/usr/bin/ld: ./src/network.c:176: undefined reference to `curl_multi_timeout'
/usr/bin/ld: ./src/network.c:188: undefined reference to `curl_multi_fdset'
/usr/bin/ld: ./src/network.c:191: undefined reference to `curl_multi_strerror'
/usr/bin/ld: ./src/network.c:206: undefined reference to `curl_multi_info_read'
/usr/bin/ld: network.o: in function `curl_process_msgs':
./src/network.c:102: undefined reference to `curl_easy_getinfo'
/usr/bin/ld: ./src/network.c:106: undefined reference to `curl_easy_getinfo'
/usr/bin/ld: ./src/network.c:110: undefined reference to `curl_easy_getinfo'
/usr/bin/ld: ./src/network.c:134: undefined reference to `curl_multi_remove_handle'
/usr/bin/ld: ./src/network.c:137: undefined reference to `curl_easy_cleanup'
/usr/bin/ld: ./src/network.c:129: undefined reference to `curl_easy_strerror'
/usr/bin/ld: network.o: in function `network_init':
./src/network.c:229: undefined reference to `curl_global_init'
/usr/bin/ld: ./src/network.c:235: undefined reference to `curl_share_init'
/usr/bin/ld: ./src/network.c:241: undefined reference to `curl_share_setopt'
/usr/bin/ld: ./src/network.c:242: undefined reference to `curl_share_setopt'
/usr/bin/ld: ./src/network.c:243: undefined reference to `curl_share_setopt'
/usr/bin/ld: ./src/network.c:250: undefined reference to `curl_share_setopt'
/usr/bin/ld: ./src/network.c:251: undefined reference to `curl_share_setopt'
/usr/bin/ld: ./src/network.c:254: undefined reference to `curl_multi_init'
/usr/bin/ld: ./src/network.c:259: undefined reference to `curl_multi_setopt'
/usr/bin/ld: ./src/network.c:261: undefined reference to `curl_multi_setopt'
/usr/bin/ld: network.o: in function `crypto_lock_init':
./src/network.c:56: undefined reference to `CRYPTO_malloc'
/usr/bin/ld: network.o: in function `network_init':
./src/network.c:278: undefined reference to `curl_version_info'
/usr/bin/ld: network.o: in function `transfer_blocking':
./src/network.c:318: undefined reference to `curl_easy_setopt'
/usr/bin/ld: ./src/network.c:320: undefined reference to `curl_multi_add_handle'
/usr/bin/ld: ./src/network.c:323: undefined reference to `curl_multi_strerror'
/usr/bin/ld: network.o: in function `transfer_nonblocking':
./src/network.c:335: undefined reference to `curl_multi_add_handle'
/usr/bin/ld: ./src/network.c:337: undefined reference to `curl_multi_strerror'
/usr/bin/ld: fuse_local.o: in function `fuse_local_init':
./src/fuse_local.c:156: undefined reference to `fuse_main_real'
/usr/bin/ld: link.o: in function `Link_to_curl':
./src/link.c:95: undefined reference to `curl_easy_init'
/usr/bin/ld: ./src/link.c:100: undefined reference to `curl_easy_setopt'
/usr/bin/ld: ./src/link.c:101: undefined reference to `curl_easy_setopt'
/usr/bin/ld: ./src/link.c:103: undefined reference to `curl_easy_setopt'
/usr/bin/ld: ./src/link.c:104: undefined reference to `curl_easy_setopt'
/usr/bin/ld: ./src/link.c:105: undefined reference to `curl_easy_setopt'
[...]
This probably has to do with API changes in libcurl4-openssl-dev ...
from httpdirfs.
fangfufu
commented on June 14, 2024
The problem is not actually due to libcurl4-openssl-dev, right now Debian Testing and Debian Unstable share the same version of libcurl4-openssl-dev. It compiles fine under Debian Testing. Debian Unstable does have a different version of GCC, I don't know if it is because of that.
from httpdirfs.
fangfufu
commented on June 14, 2024
Phew, it took me a while to figure out what was going on. Ok, I fixed it now. The fix is in 97ecbff. I changed the location of $(LDFLAGS). This is because collect2 now has the -as-needed flag. So the linker is now sensitive to the relative position of the object files and the libraries in the command line.
It is basically this error:
https://bugs.launchpad.net/ubuntu/+source/gcc-4.8/+bug/1271468
For more details, have a look at:
https://wiki.ubuntu.com/NattyNarwhal/ToolchainTransition#How_to_Fix_a_Problem
https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries
from httpdirfs.
fangfufu
commented on June 14, 2024
@jcharaoui , I added some pragmas to suppress -Wunused-function warnings for the thread lock functions OpenSSL. Those functions were needed during Debian Stretch, they became obsolete in Debian Buster. However I am not removing them from the code for now, as people are still using Debian Stretch.
from httpdirfs.
jcharaoui
commented on June 14, 2024
@fangfufu I suggest to remove the functions. I'll create a backport package that includes the required functions (via debian/patches)
from httpdirfs.
fangfufu
commented on June 14, 2024
@jcharaoui I prefer to leave them in, unless there is a technical reason that they should be out. I don't see why we should break backward compatibility. Additionally this software might get used by non-Debian users.
from httpdirfs.
fangfufu
commented on June 14, 2024
The new version had been uploaded to Debian. :-)
from httpdirfs.
Related Issues (20)
- arg -o should be possible after destination (mount.fuse compatability)
- Unable to mount from fstab or /bin/mount HOT 1
- getopt_long returns an int, not a char, and this matters a lot
- Windows support HOT 1
- Support for h5ai(HTML5 Apache Index) directory listing HOT 4
- Add `--cacert` option like `curl`'s frontend
- LinkTable_print(): Invalid link count: 0, h HOT 1
- How to cleanly clear cache HOT 4
- Reconsider usage of UBSAN HOT 3
- Transition to libfuse 3.x HOT 1
- Unable to install on Linux HOT 2
- Cache causes corrupt data when filesystem is full HOT 6
- Why not add a resumable upload function? HOT 7
- Improper locking error, unlocking an inactive lock? HOT 6
- wishlist: Cache for directories / metadata only / small files only
- Trailing slash in links not preserved HOT 4
- 404'ing directory breaks httpdirfs
- httpdirfs missing mountpoint parameter, rpi 4b 64bit HOT 8
- Single file mode does not work on a lot of pages HOT 2
- Single File Mode does not seem to work Linux Mint 20.2 Cinnamon HOT 31
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from httpdirfs.