Giter Club home page Giter Club logo

Comments (8)

therelapse avatar therelapse commented on June 2, 2024 2

We also encountered this problem. However, Safari version 17.5 has now been released and the window began to close normally, without updating the fancyapps/ui package.

from ui.

fancyapps avatar fancyapps commented on June 2, 2024

Hi! Thanks for the reporting! This is something with Safari v17.4 as it works fine in previous versions. This will be fixed in the next release.

from ui.

brendon avatar brendon commented on June 2, 2024

No worries @fancyapps :) Safari introduced a new engine for inline content in 17.4 that has also wrecked some layout stuff for us around radio buttons and labels. All the best :)

from ui.

fancyapps avatar fancyapps commented on June 2, 2024

It should be fixed in the latest release - https://jsfiddle.net/1zqckn4p/

from ui.

brendon avatar brendon commented on June 2, 2024

Looks good to me :) Thanks again @fancyapps.

from ui.

brendon avatar brendon commented on June 2, 2024

Hi @fancyapps, sorry to be a pain but it still seems to be a problem in my particular app (not in the jsfiddle though). Are you able to let me know how you solved it in case I'm overriding some CSS or something in my particular situation?

from ui.

fancyapps avatar fancyapps commented on June 2, 2024

@brendon First, are you sure you are using the latest version? Because, if you're using standard CDN links, for example, you might be using a cached previous version. The jsfiddle demo I gave earlier uses a fixed version of 5.0.36.

Then, could you share an online page/demo? If you don't want to post this publicly, please join Discord and DM me.

Anyway, I believe this is a Safari bug. It triggers a CSS animation on an element after it changes the parent DOM element, even if the element has style="display:none" and CSS class, that previously triggered the CSS animation, is removed. The only way I could think of to fix this is to trigger the reflow after setting display:none, otherwise Safari ignores this style and not only makes the element visible, but also runs the animation.

from ui.

brendon avatar brendon commented on June 2, 2024

I feel like an idiot, I set a resolutions override in my package.json to keep it at version 5.0.33 because of the bug. Sorry to have wasted your time!

That was an interesting explanation. Certainly sounds like a bug in Safari. Not sure how readily they fix those though...

from ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.