Comments (2)
The location view looks really slick. The only issue I see is that the design does not currently support multiple types. This goes for both the common name title and scientific name subtitle (how should this look if there are multiple types) and the "Other Resources" section, which when there are multiple types could have multiple e.g. "Wikipedia" URLs, one for each type.
There will most likely be a page for each type eventually, and the "Other Resources" can be moved there, but this still means that the title/subtitle view needs to be amended to support multiple types and each type needs to be clickable.
When loading a location from a URL (e.g. https://falling-fruit.vercel.app/entry/3383), the location info is populated but the map remains at the default global view. It should probably be zoomed in and centered on the location, and the location placemark on the map should be highlighted in some way (e.g. halo).
Let me know if this is a good place for this feedback, or if you would prefer I open separate issues for each of these.
from falling-fruit-web.
Closed by #32, and various other improvements. We still need to zoom in on the location when loading it from a URL. This will be resolved in a future PR that also implements the ability to share the map viewport in the link independently of the selected entry. (Very similar to Google Maps)
from falling-fruit-web.
Related Issues (20)
- support "back" button in the browser for map changes HOT 1
- Improve UX for when fetching location fails
- Ask for high accuracy geolocation
- Integrate location type categories HOT 5
- Show error when trying to access edit location / review form for a bad id
- In development, sometimes a map can crash from a mix of changing bounds and fetching locations
- Searching in the list view sometimes doesn't update locations on list
- on mobile, map reloads every time user flips between map and the other mobile tabs
- toast the error on failed search HOT 2
- on mobile, don't show the map in background behind the new location form
- Clarify intended interaction with new location / edit location marker HOT 1
- improve zoom in / out effects related to add/edit location actions HOT 3
- Regression: Cannot move map when location drawer is open HOT 1
- Keep search box content around after navigating away
- On mobile, allow going back and forth between location picker and form
- Refactor: state of current location/review should be in Redux HOT 1
- mobile: "add new location" state is lost when going to settings and back HOT 1
- Can't update a review with a photo added from the old website HOT 1
- (desktop) for new location, move the marker, not the map
- (mobile) /data and /imports highlight an incorrect tab
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from falling-fruit-web.