I'd like to increase the Provider test coverage a bit. To do so I checked out the exis

Use seed() in tests? about faker HOT 4 CLOSED

fakerphp commented on September 25, 2024

Use seed() in tests?

from faker.

Comments (4)

pimjansen commented on September 25, 2024 1

Closing this since we updated the seeding used in setup. If changes are still required feel free to raise a pr fornthis

from faker.

IonBazan commented on September 25, 2024

Good point - I've noticed some inconsistency there too. What do you think about putting it in setUp() method in \Faker\Test\TestCase and making sure all tests are extending this class? That would reduce code duplication for:

$this->faker = new Generator();
$this->faker->seed(1);

While we are here, we could replace the second argument for mt_srand to MT_RAND_MT19937 as we already require PHP 7.1 so no need to keep the compatibility with previous versions:

Faker/src/Faker/Generator.php

Lines 217 to 224 in 6366793

 public function seed($seed = null) 

 { 

 if ($seed === null) { 

 mt_srand(); 

 } else { 

 mt_srand((int) $seed, MT_RAND_PHP); 

 } 

 }

But that would be a breaking change.

from faker.

pimjansen commented on September 25, 2024

Agree on the default seed set in the setup. The MTRand for now is fine. Lets bump that in 2.x

from faker.

krsriq commented on September 25, 2024

The downside of seeding the random number generator for all tests would of course be that our tests would miss cases that only occur sometimes/randomly.

from faker.

Use seed() in tests? about faker HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	public function seed($seed = null)
	{
	if ($seed === null) {
	mt_srand();
	} else {
	mt_srand((int) $seed, MT_RAND_PHP);
	}
	}