Unknown formatter "catchPhrase" about faker HOT 7 CLOSED

As far as i know this has always been a locale specific method for en_US and never for the GB locale here.

So i do not really think it is a bug

from faker.

@pimjansen it has definitely been available to en_GB as I use it in most of my Laravel applications.

It was working before I updated to the latest version today.

from faker.

The en_GB locale only has a new Company class since january 2021. Before this it did not even exist and that class never had a catchPhrase method. It only exists in the en_US locale.

Therefor i also do not see this as a bug.

from faker.

@pimjansen The commit I referenced did include the new en_GB Company class as you say, which is the problem.

The class didn't exist before this commit which meant that the default fallback was the en_US Company class as shown here:

https://github.com/FakerPHP/Faker/blob/main/src/Faker/Factory.php#L7

So before the new en_GB Company class was created ->catchPhrase worked as it fell back to en_US, but the newly created en_GB doesn't contain this method - causing the issue.

from faker.

I believe that ->catchPhrase will be used in many other Laravel applications with the locale set to en_GB - so I propose that this method is moved into either the base Company class or added to the en_GB class too.

I'd be happy to submit a PR with either of the above solutions.

from faker.

Feel free to raise a PR for this. Meaning implementing the catchPhrase methods on the en_GB provider if needed. Please note that we do not want linking between the locales itself.

from faker.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 1 week if no further activity occurs. Thank you for your contributions.

from faker.