Extension-free US phone numbers about faker HOT 10 CLOSED

Do you have some more info on what is invalid there and what you expect?

Please ensure the bugreport is valid as mentioned in the template

from faker.

I have had to add regex to strip out the “x5555” from Faker phone numbers just so my tests won’t break.

from faker.

@hopeseekr do we even know where the X is for? Looking at the wiki i dont see it existing in any spec.

However im not from the regionso for me it is hard to tell

from faker.

@pimjansen it indicates an extension, usually not dialed with the phone number but after connecting to a main relay. They are not uncommon but individuals would never have extensions, it is an indicator of a business number.

from faker.

@pimjansen it indicates an extension, usually not dialed with the phone number but after connecting to a main relay. They are not uncommon but individuals would never have extensions, it is an indicator of a business number.

So therefor they are valid?

from faker.

That depends on who you ask! The reason I opened this issue is that they aren't considered valid by Stripe or Firebase (probably among others). They are never valid programmatically, as in you cannot dial them. However people in the USA would understand what they meant and how to use them, and you may not be able to reach the desired person without the extra info.

from faker.

In my opinion the appropriate way to handle these should have been to have extension be a separate endpoint. I'm not sure if changing it now would be considered BC

from faker.

Well imo a phonenumber is reachable by a phone. Meaning that if it is a number that you can not dial it is not ok and should not be in the output.

To keep it simple we ofcourse want to create these numbers at any point. Therefor i think it is best to add a method to generate the numbers that are now considered wrong and update the existing one.

Will that work?

from faker.

Absolutely! That would be awesome. So to be clear, this would be something like:

• Add phoneNumberWithExtension // '201-886-0269 x3767'
• Adjust existing phoneNumber // '919-824-1234'

from faker.

Absolutely! That would be awesome. So to be clear, this would be something like:

• Add phoneNumberWithExtension // '201-886-0269 x3767'
• Adjust existing phoneNumber // '919-824-1234'

Yes would work for me

from faker.