Giter Club home page Giter Club logo

Comments (10)

facundoolano avatar facundoolano commented on June 1, 2024

This has been brought up before and fixed, what version of the module are you using?

from app-store-scraper.

bryan avatar bryan commented on June 1, 2024

Currently, app-store-scraper: 0.5.1 obtained via NPM

screen shot 2017-03-05 at 10 30 42 am

from app-store-scraper.

facundoolano avatar facundoolano commented on June 1, 2024

Can you show me an example to reproduce the error?

from app-store-scraper.

bryan avatar bryan commented on June 1, 2024

Take a look at the entry section which is being sliced between these two json responses:
https://itunes.apple.com/us/rss/customerreviews/page=1/id=389801252/sortby=mostRecent/json

versus

https://itunes.apple.com/ro/rss/customerreviews/page=1/id=389801252/sortby=mostRecent/json

a
b

from app-store-scraper.

facundoolano avatar facundoolano commented on June 1, 2024

I mean a code snippet with the data you need to input to generate the error you are seeing.

from app-store-scraper.

bryan avatar bryan commented on June 1, 2024

I have a bit of things on my hands currently and won't be able to create a test example at the moment. You can feel free to test it on your own. I temporarily fixed things locally on my end, but the error derives from results.feed.entry being a Dictionary instead of an Array of Dictionary.

from app-store-scraper.

facundoolano avatar facundoolano commented on June 1, 2024

I was asking for something as simple as this:

store = require('app-store-scraper');
store.reviews({id: 389801252});

But well, now that I can reproduce I can look into fixing it. I also have a lot of things in my hands, so I can't tell when that will happen.

from app-store-scraper.

bryan avatar bryan commented on June 1, 2024

I had to go through the different locales before the error popped up for that one instance - hence why I gave you the JSON format and specific examples to my issue and can't copy and paste my implementation without having to refactor it to run properly, sorry about that inconvenience.

You can use the locales here and loop through all the pages 1 to 10 for each locale, sort by RECENT, and the id is correctly listed as 389801252 for Instagram for which I ran into the bug:

var regionList = ["ae", "ag", "ai", "al", "am", "ao", "ar", "at", "au", "az", "bb", "be", "bf", "bg", "bh", "bj", "bm", "bn", "bo", "br", "bs", "bt", "bw", "by", "bz", "ca", "cg", "ch", "cl", "cn", "co", "cr", "cv", "cy", "cz", "de", "dk", "dm", "do", "dz", "ec", "ee", "eg", "es", "fi", "fj", "fm", "fr", "gb", "gd", "gh", "gm", "gr", "gt", "gw", "gy", "hk", "hn", "hr", "hu", "id", "ie", "il", "in", "is", "it", "jm", "jo", "jp", "ke", "kg", "kh", "kn", "kr", "kw", "ky", "kz", "la", "lb", "lc", "lk", "lr", "lt", "lu", "lv", "md", "mg", "mk", "ml", "mn", "mo", "mr", "ms", "mt", "mu", "mw", "mx", "my", "mz", "na", "ne", "ng", "ni", "nl", "no", "np", "nz", "om", "pa", "pe", "pg", "ph", "pk", "pl", "pt", "pw", "py", "qa", "ro", "ru", "sa", "sb", "sc", "se", "sg", "si", "sk", "sl", "sn", "sr", "st", "sv", "sz", "tc", "td", "th", "tj", "tm", "tn", "tr", "tt", "tw", "tz", "ua", "ug", "us", "uy", "uz", "vc", "ve", "vg", "vn", "ye", "za", "zw"];

I'm going to close this, feel free to reopen this or create a new issue when you decide to update it. Thanks.

from app-store-scraper.

facundoolano avatar facundoolano commented on June 1, 2024

I'm leaving this open since I can reproduce the error with id 389801252.

from app-store-scraper.

facundoolano avatar facundoolano commented on June 1, 2024

this was fixed by the changes in #19

from app-store-scraper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.