Was: linting/testing Updated: 19/04/17 drop 2.x support about commai-env HOT 10 CLOSED

Hi Stephen,

We would certainly be happy to integrate style fixes into the code, thanks!
Regarding the python version to use, I would personally prefer to keep the code compatible to as many python installations as possible in order to keep the requirements simple. There are still many people who run python 2.7 (and some don't even care what version of python they are using) and I would thus prefer not to impose on them arbitrary requirements if that can be avoided.

from commai-env.

I have a few discussion points I would like some feedback on before generating commits for this implementation of the CommAI-env paper:

1. Python >=3.5 This is a major point to me, I think the urge support Python 2.7 as an accessibility feature, should be reevaluated with the following in mind:

• With the general goal being to create a stable, standard environment, having 2.7 and 3.x python within the same app creates potentially thousands of possible environments, based on the host computers current Python(s) and package installations. Each possible configuration could impact the performance, and make it ineffective to use for qualitative purposes.

• Attempting to have the code run nativity in both 2 and 3 environments adds a great deal of unnecessary complexity, counter to the goals

• Python 2.7 End of Life is 2020, after which it will not be supported with security patches or bug updates. Python 3.5 is a long term support version, helping prevent code rot, and major refactors that will invalidate all previously recorded qualitative data for comparison purposes..

• Having both overlapping packages, builtins, and functions from 2/3 make the env unstable and prone to exploitation from the machine learning AI operating within it's scope. Once again detracting from it's utility to produce consistent results session to session and AI to AI.

2. The CommAI-env should be 'pure' python, tested and linted as such. Much of the current code was written in a blend of python and (unintentional) C structure and syntax. This has contributed to the use of reserved python words, and builtin's, being used for class, function and variable names, ie 'input' being used as a variable name, shadowing the Python3 input(), but not Python2 raw_input().

I don't want to spam suggestions, if there is agreement the change should be implemented, I will take on the job.

I've been working on a downstream version of the CommAI-env used in Round1 of the challenge, with the hope of bringing the Rould1 code to a working level. After a week doing some basic cleanup and de-entangling the spaghetti enough to evaluate it, I have moved to the upstream.

I do want to compliment the programmers here on the quality of the the overall structure and verbose in-line documentation. I look forward to the opportunity to contribute to the fine tuning, and to assist with enhancing Comm-env to a general release state .

from commai-env.

I'm afraid this discussion has become a moot point, it appears the development by facebookresearch(er)' s, concluded with the beta-testing release. Due to a lack of ongoing work here, I have created a separate project, based on this body of work, with a BSD 2, 3rd clause license at https://github.com/stephenbhope/Revised-CommAI-env if any would care to participate in further development, or to keep abreast of the status.

Best Regards,

Stephen Hope

from commai-env.

Hi Stephen,

Thanks for your comments. I think for now there is a sufficiently large community so that it would be quite troublesome to drop support for a major python revision. For future iterations we could consider what you are suggesting, but for now I think it will be better to maintain compatibility with both versions. This does not mean we are not interested in improving and advancing the development of the CommAI platform, quite the contrary! We have been pushing improvements and fixes and will continue to do so!

Thanks,
Germán

from commai-env.

from commai-env.

from commai-env.

from commai-env.

from commai-env.

Apologies to all for the tailing quote, I was responding via email.

@boyd, I do want to alert you to my existing relationship with facebookrearch is limited to signed CLI agreement for this repository, and am not affiliated with any third parties who may governed by another agreement.

I'm interested in the discussion, but clearly understand if the group you are addressing does not invite outside participation. :)

Steve

from commai-env.

@boydlever Please see previous updated comment. I've released you are likely not aware the only reason I am receiving your replies is they are being routed to, and echoed from: #34
A closed issue thread I started and am subscribed to via email.

My email is: [email protected]

from commai-env.